Skip to content

use chalk, yargs, y18n, yargonaut #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2017
Merged

use chalk, yargs, y18n, yargonaut #5

merged 2 commits into from
Mar 12, 2017

Conversation

@jrappen
Copy link
Contributor

@jrappen jrappen commented Mar 12, 2017 •
edited
Loading

Fair warning, I'm not a Javascript guy.

  • added .editorconfig
  • use chalk and yargs instead of commander and custom function
  • changed script name test to lint (cause that's what it is?)

I wasn't sure how to test this. Feedback is welcome, should I need to change anything.
@jrappen
Copy link
Contributor Author

jrappen commented Mar 12, 2017

For yargs should be able to use .locale in combination with .updateStrings. Haven't found out how exactly, yet. Will update as soon as I did.
@jrappen jrappen changed the title use yargs and chalk use chalk, yargs, y18n, yargonaut Mar 12, 2017
@jrappen
Copy link
Contributor Author

jrappen commented Mar 12, 2017

@QingWei-Li Not sure whether or not chalk should be in package.json. yargonaut uses it.
QingWei-Li
QingWei-Li approved these changes Mar 12, 2017
View reviewed changes
Copy link
Member

@QingWei-Li QingWei-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.
@QingWei-Li
Copy link
Member

QingWei-Li commented Mar 12, 2017

@jrappen chalk is required if the user is using npm 2
@QingWei-Li QingWei-Li merged commit 0447821 into docsifyjs:master Mar 12, 2017
@QingWei-Li
Copy link
Member

QingWei-Li commented Mar 12, 2017

@jrappen
Thank you for your contribution.
I tried it, but it did not work for me.

➜ docsify-cli git:(master) ✗ docsify serve docs ➜ docsify-cli git:(master) ✗

😢
@jrappen
Copy link
Contributor Author

jrappen commented Mar 12, 2017

feel free to revert, I'll review the yargs docs
@QingWei-Li QingWei-Li mentioned this pull request Mar 12, 2017
Merged
@jrappen
Copy link
Contributor Author

jrappen commented Mar 12, 2017

apparently I cannot put .option after builder: (yargs) => return yargs
@jrappen jrappen mentioned this pull request Mar 13, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@jrappen @QingWei-Li