Ignore node_modules for metalsmith #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| .destination(meta.dist) | ||
| .metadata(meta) | ||
| .ignore('node_modules') | ||
| .ignore(`!**/{${meta.docs}{,/**/*},*.md}`) |
Contributor
There was a problem hiding this comment.
I think my line of thinking was that this was enough to get node_modules ignored. I guess it wasn't!
kjantzer added a commit to kjantzer/docpress-core that referenced this pull request Nov 6, 2018
kjantzer added a commit to kjantzer/docpress-core that referenced this pull request Nov 6, 2018
Related to docpress#91; also helps solve #230
knownasilya pushed a commit that referenced this pull request Nov 6, 2018
Related to #91; also helps solve docpress/docpress#230 Also fixes #197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Prevent metalsmith from crashing docpress by ignoring
node_modules. Might be a good ideato add an option to pass through ignore options, just in case people have big projects or something similar.
Resolves docpress/docpress#113