Skip to content

Proposed SPLIT_CHUNKS config option #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Proposed SPLIT_CHUNKS config option #173

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8713e8f
Proposed SPLIT_CHUNKS config option
mkgs Sep 19, 2018
5c984ed
Load multiple bundles using comma-sep bundle name
mkgs Oct 19, 2018
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Load multiple bundles using comma-sep bundle name 
If the SPLIT_CHUNKS config option is set, allow loading of multiple bundles at once. Ensures we load common dependencies only once.
  • Loading branch information
@mkgs
mkgs committed Oct 19, 2018
commit 5c984edef7c025d4ed1805b7c8a913ce4197f858
3 changes: 2 additions & 1 deletion webpack_loader/loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,9 @@ def get_bundle(self, bundle_name):
if assets.get('status') == 'done':
if self.config['SPLIT_CHUNKS']:
chunks = list()
bundle_names = set(bundle_name.split(','))
for chunk_name, chunk in assets['chunks'].items():
if bundle_name in chunk_name.split('~'):
if bundle_names & set(chunk_name.split('~')):
chunks.extend(chunk)
else:
chunks = assets['chunks'].get(bundle_name, None)
Expand Down