Undo refactoring for single-use-site functions.

Author: nedtwigg

src/lib/enhancers/github/GitHubEditEnhancer.tsx

@@ -9,8 +9,8 @@ import { logger } from "@/lib/logger"
 import { fixupOvertype, modifyDOM } from "../overtype-misc"
 import {
  commonGitHubOptions,
- isProjectUrl,
  isInProjectCommentBox,
+ isProjectUrl,
  parseProjectIssueParam,
  prepareGitHubHighlighter,
 } from "./github-common"

src/lib/enhancers/github/GitHubIssueAppendEnhancer.tsx

@@ -11,9 +11,8 @@ import { logger } from "@/lib/logger"
 import { fixupOvertype, modifyDOM } from "../overtype-misc"
 import {
  commonGitHubOptions,
- extractProjectIssueTitle,
- isProjectUrl,
  isInProjectCommentBox,
+ isProjectUrl,
  parseProjectIssueParam,
  prepareGitHubHighlighter,
 } from "./github-common"
@@ -29,7 +28,8 @@ export interface GitHubIssueAppendSpot extends CommentSpot {
 }
 
 export class GitHubIssueAppendEnhancer
- implements CommentEnhancer<GitHubIssueAppendSpot> {
+ implements CommentEnhancer<GitHubIssueAppendSpot>
+{
  forSpotTypes(): string[] {
  return [GH_ISSUE_APPEND]
  }
@@ -60,7 +60,10 @@ export class GitHubIssueAppendEnhancer
  if (issueInfo) {
  const unique_key = `github.com:${issueInfo.slug}:${issueInfo.number}`
  // For project views, the title is in the side panel dialog
- const title = extractProjectIssueTitle()
+ const title =
+ document
+ .querySelector('[data-testid="issue-title"]')
+ ?.textContent?.trim() || ""
  return {
  domain: location.host,
  number: issueInfo.number,

src/lib/enhancers/github/GitHubIssueCreateEnhancer.tsx

@@ -10,7 +10,6 @@ import { logger } from "../../logger"
 import { fixupOvertype, modifyDOM } from "../overtype-misc"
 import {
  commonGitHubOptions,
- extractDialogSlug,
  isProjectUrl,
  prepareGitHubHighlighter,
 } from "./github-common"
@@ -25,7 +24,8 @@ export interface GitHubIssueCreateSpot extends CommentSpot {
 }
 
 export class GitHubIssueCreateEnhancer
- implements CommentEnhancer<GitHubIssueCreateSpot> {
+ implements CommentEnhancer<GitHubIssueCreateSpot>
+{
  forSpotTypes(): string[] {
  return [GH_ISSUE_CREATE]
  }
@@ -46,8 +46,10 @@ export class GitHubIssueCreateEnhancer
  // Check if we're in a "Create new issue" dialog
  const dialog = textarea.closest('[role="dialog"]')
  if (dialog) {
- const slug = extractDialogSlug(dialog)
- if (slug) {
+ const dialogHeading = dialog.querySelector("h1")?.textContent
+ const slugMatch = dialogHeading?.match(/Create new issue in (.+)/)
+ if (slugMatch) {
+ const slug = slugMatch[1]!
  const unique_key = `github.com:${slug}:new`
  const titleInput = document.querySelector(
  'input[placeholder="Title"]'

src/lib/enhancers/github/github-common.ts

@@ -107,26 +107,3 @@ export function parseProjectIssueParam(
 export function isInProjectCommentBox(element: HTMLElement): boolean {
  return !!element.closest('[class*="Shared-module__CommentBox"]')
 }
-
-/**
- * Extract the issue title from a project view.
- * Used when viewing issues within a project board.
- */
-export function extractProjectIssueTitle(): string {
- return (
- document
- .querySelector('[data-testid="issue-title"]')
- ?.textContent?.trim() || ""
- )
-}
-
-/**
- * Extract the repository slug from a "Create new issue" dialog heading.
- * Heading format: "Create new issue in owner/repo"
- * Returns: "owner/repo" or null if not found
- */
-export function extractDialogSlug(dialog: Element): string | null {
- const dialogHeading = dialog.querySelector("h1")?.textContent
- const slugMatch = dialogHeading?.match(/Create new issue in (.+)/)
- return slugMatch ? slugMatch[1]! : null
-}