make sure that we run our show code when a custom editor is shown (microsoft#14022)

* make sure that we run our show code when a custom editor is shown * Trigger notebook load in the constructor, not show Co-authored-by: Ian Huff <ianhuff@CEIDCCEVIPSVC01.redmond.corp.microsoft.com>

Author: IanMatthewHuff

news/2 Fixes/14016.md

@@ -0,0 +1 @@
+Have Custom Editors load on editor show unless autostart is disabled. 

src/client/datascience/interactive-common/interactiveBase.ts

@@ -216,14 +216,11 @@ export abstract class InteractiveBase extends WebviewPanelHost<IInteractiveWindo
 
  // When the variable service requests a refresh, refresh our variable list
  this.disposables.push(this.jupyterVariables.refreshRequired(this.refreshVariables.bind(this)));
- }
-
- public async show(preserveFocus: boolean = true): Promise<void> {
- // Verify a server that matches us hasn't started already
- this.createNotebookIfProviderConnectionExists().ignoreErrors();
 
- // Show our web panel.
- return super.show(preserveFocus);
+ // If we have already auto started our server then we can go ahead and try to create a notebook on construction
+ setTimeout(() => {
+ this.createNotebookIfProviderConnectionExists().ignoreErrors();
+ }, 0);
  }
 
  // tslint:disable-next-line: no-any no-empty cyclomatic-complexity max-func-body-length
@@ -610,7 +607,7 @@ export abstract class InteractiveBase extends WebviewPanelHost<IInteractiveWindo
  await this.ensureDarkSet();
 
  // Then show our webpanel
- await this.show();
+ await this.show(true);
 
  // Add our sys info if necessary
  if (file !== Identifiers.EmptyFileName) {

src/client/datascience/interactive-ipynb/nativeEditor.ts

@@ -240,7 +240,7 @@ export class NativeEditor extends InteractiveBase implements INotebookEditor {
  this.previouslyNotTrusted = !this._model.isTrusted;
  }
 
- public async show(preserveFocus?: boolean) {
+ public async show(preserveFocus: boolean = true) {
  await this.loadPromise;
  return super.show(preserveFocus);
  }

src/client/datascience/interactive-window/interactiveWindow.ts

@@ -197,7 +197,7 @@ export class InteractiveWindow extends InteractiveBase implements IInteractiveWi
  }
  }
 
- public async show(preserveFocus?: boolean): Promise<void> {
+ public async show(preserveFocus: boolean = true): Promise<void> {
  await this.loadPromise;
  return super.show(preserveFocus);
  }

src/client/datascience/notebookStorage/nativeEditorProvider.ts

@@ -276,7 +276,7 @@ export class NativeEditorProvider implements INotebookEditorProvider, CustomEdit
  // Get the model
  const model = await this.loadModel({ file: resource });
 
- // Load it (should already be visible)
+ // Load it
  return this.createNotebookEditor(model, panel);
  } catch (exc) {
  // Send telemetry indicating a failure