Change title of file explorer dialog when browsing for an interpreter (microsoft#13036)

* Update @types/vscode * Add a `title` parameter to the "open" dialog box - Gets the localized title via `localize.ts`. * Update the appropriate unit test * Add a news entry * Add an appropriate entry to `package.nls.json` * Update news/1 Enhancements/12959.md Co-authored-by: Kartik Raj <karraj@microsoft.com>

Author: pralkarz

news/1 Enhancements/12959.md

@@ -0,0 +1 @@
+The file explorer dialog now has an appropriate title when browsing for an interpreter. (thanks [ziebam](https://github.com/ziebam))

package-lock.json

@@ -3379,7 +3379,7 @@
  "@types/tmp": "0.0.33",
  "@types/untildify": "^3.0.0",
  "@types/uuid": "^3.4.3",
- "@types/vscode": "^1.46.0",
+ "@types/vscode": "^1.47.0",
  "@types/webpack-bundle-analyzer": "^2.13.0",
  "@types/winreg": "^1.2.30",
  "@types/ws": "^6.0.1",

package.json

@@ -179,6 +179,7 @@
  "InterpreterQuickPickList.enterPath.placeholder": "Enter path to a Python interpreter.",
  "InterpreterQuickPickList.browsePath.label": "Find...",
  "InterpreterQuickPickList.browsePath.detail": "Browse your file system to find a Python interpreter.",
+ "InterpreterQuickPickList.browsePath.title": "Select Python interpreter",
  "diagnostics.upgradeCodeRunner": "Please update the Code Runner extension for it to be compatible with the Python extension.",
  "Common.bannerLabelYes": "Yes",
  "Common.bannerLabelNo": "No",

package.nls.json

@@ -187,7 +187,8 @@ export namespace InterpreterQuickPickList {
  'InterpreterQuickPickList.browsePath.detail',
  'Browse your file system to find a Python interpreter.'
  ),
- openButtonLabel: localize('python.command.python.setInterpreter.title', 'Select Interpreter')
+ openButtonLabel: localize('python.command.python.setInterpreter.title', 'Select Interpreter'),
+ title: localize('InterpreterQuickPickList.browsePath.title', 'Select Python interpreter')
  };
 }
 export namespace ExtensionChannels {

src/client/common/utils/localize.ts

@@ -112,7 +112,8 @@ export class SetInterpreterCommand extends BaseInterpreterSelectorCommand {
  const uris = await this.applicationShell.showOpenDialog({
  filters: this.platformService.isWindows ? filtersObject : undefined,
  openLabel: InterpreterQuickPickList.browsePath.openButtonLabel(),
- canSelectMany: false
+ canSelectMany: false,
+ title: InterpreterQuickPickList.browsePath.title()
  });
  if (uris && uris.length > 0) {
  state.path = uris[0].fsPath;

src/client/interpreter/configuration/interpreterSelector/commands/setInterpreter.ts

@@ -244,7 +244,8 @@ suite('Set Interpreter Command', () => {
  const expectedParams = {
  filters: filtersObject,
  openLabel: InterpreterQuickPickList.browsePath.openButtonLabel(),
- canSelectMany: false
+ canSelectMany: false,
+ title: InterpreterQuickPickList.browsePath.title()
  };
  const multiStepInput = TypeMoq.Mock.ofType<IMultiStepInput<InterpreterStateArgs>>();
  multiStepInput
@@ -268,7 +269,8 @@ suite('Set Interpreter Command', () => {
  const expectedParams = {
  filters: undefined,
  openLabel: InterpreterQuickPickList.browsePath.openButtonLabel(),
- canSelectMany: false
+ canSelectMany: false,
+ title: InterpreterQuickPickList.browsePath.title()
  };
  multiStepInput
  .setup((i) => i.showQuickPick(TypeMoq.It.isAny()))