Allow psr/http-message ^2 #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Also allow expected composer plugins and set minimum php version to keep lockfile compatible with lowest supported version . Adds parameter and return type hints to all test stubs for psr/http-message v2 compatibility. Some tests will fail due to incompatible signatures when deps are at lowest.
- Install correct PHPUnit requirement on newer PHP versions
gsteel force-pushed the allow-psr-http-messsage-2 branch from 9f65983 to 17f6738 Compare - Install correct PHPUnit requirement on newer PHP versions - Only upload coverage when the repository matches `dflydev/dflydev-fig-cookies`
1 task
internalsystemerror approved these changes May 31, 2023
Collaborator Author
| @simensen - Hate to be a nag, but is there any chance you could take a look at this one? |
1 task
gsteel added enhancement dependencies Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Also allow expected composer plugins and set minimum php version to keep lockfile compatible with lowest supported version of PHP.
Adds parameter and return type hints to all test stubs for psr/http-message v2 compatibility. Some tests will fail due to incompatible signatures when deps are at lowest - hopefully this is acceptable for test code considering tests don't appear to run with
--prefer-lowestAlso adds 8.1 and 8.2 to the matrix