Skip to content

Commit afbb399

Browse files
Merge pull request HubSpot#59 from HubSpot/is-open-prop-change-should-trigger-close-menu
Trigger closeMenu when isOpen changes from true to false
2 parents 2bcb998 + 0999ba6 commit afbb399

File tree

6 files changed

+22
-2
lines changed

6 files changed

+22
-2
lines changed

dist/react-select-plus.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1161,6 +1161,10 @@ var Select = _react2['default'].createClass({
11611161

11621162
var valueArray = this.getValueArray(nextProps.value, nextProps);
11631163

1164+
if (!nextProps.isOpen && this.props.isOpen) {
1165+
this.closeMenu();
1166+
}
1167+
11641168
if (nextProps.required) {
11651169
this.setState({
11661170
required: this.handleRequired(valueArray[0], nextProps.multi)

dist/react-select-plus.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

examples/dist/bundle.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1461,6 +1461,10 @@ var Select = _react2['default'].createClass({
14611461

14621462
var valueArray = this.getValueArray(nextProps.value, nextProps);
14631463

1464+
if (!nextProps.isOpen && this.props.isOpen) {
1465+
this.closeMenu();
1466+
}
1467+
14641468
if (nextProps.required) {
14651469
this.setState({
14661470
required: this.handleRequired(valueArray[0], nextProps.multi)

examples/dist/standalone.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1161,6 +1161,10 @@ var Select = _react2['default'].createClass({
11611161

11621162
var valueArray = this.getValueArray(nextProps.value, nextProps);
11631163

1164+
if (!nextProps.isOpen && this.props.isOpen) {
1165+
this.closeMenu();
1166+
}
1167+
11641168
if (nextProps.required) {
11651169
this.setState({
11661170
required: this.handleRequired(valueArray[0], nextProps.multi)

lib/Select.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -275,6 +275,10 @@ var Select = _react2['default'].createClass({
275275

276276
var valueArray = this.getValueArray(nextProps.value, nextProps);
277277

278+
if (!nextProps.isOpen && this.props.isOpen) {
279+
this.closeMenu();
280+
}
281+
278282
if (nextProps.required) {
279283
this.setState({
280284
required: this.handleRequired(valueArray[0], nextProps.multi)

src/Select.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,10 @@ const Select = React.createClass({
222222

223223
const valueArray = this.getValueArray(nextProps.value, nextProps);
224224

225+
if (!nextProps.isOpen && this.props.isOpen) {
226+
this.closeMenu();
227+
}
228+
225229
if (nextProps.required) {
226230
this.setState({
227231
required: this.handleRequired(valueArray[0], nextProps.multi),

0 commit comments

Comments
 (0)