fix: implement deep clone for Har and Log objects #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The splitLogEntries() method was doing a shallow clone, which meant that modifying the cloned object's log entries also modified the original object's entries. This commit implements __clone() methods in both Har and Log classes to ensure proper deep cloning: - Har::__clone() deep clones the Log object - Log::__clone() deep clones all object properties (Creator, Browser, Pages, Entries) with proper isset() checks to handle uninitialized properties Added testCloneIsDeep() to verify that modifying a cloned Har object doesn't affect the original.
Added testCloneBrowserIsDeep() to verify that the Browser object within the Log is properly deep cloned. This ensures that modifying the Browser in a cloned Har object doesn't affect the original.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The splitLogEntries() method was doing a shallow clone, which meant that modifying the cloned object's log entries also modified the original object's entries.
This commit implements __clone() methods in both Har and Log classes to ensure proper deep cloning:
Added testCloneIsDeep() to verify that modifying a cloned Har object doesn't affect the original.