Skip to content

Commit 63ff0a0

Browse files
committed
[C++] Upgrade to Google Test 1.8.0 and make build more similar with Aeron.
1 parent 2c0a770 commit 63ff0a0

File tree

4 files changed

+10
-9
lines changed

4 files changed

+10
-9
lines changed

CMakeLists.txt

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,10 @@ if(SBE_TESTS)
4949

5050
ExternalProject_Add(
5151
gtest
52-
URL ${CMAKE_CURRENT_SOURCE_DIR}/sbe-tool/src/test/lib/gtest-1.7.0.zip
53-
URL_MD5 2d6ec8ccdf5c46b05ba54a9fd1d130d7
52+
URL ${CMAKE_CURRENT_SOURCE_DIR}/cppbuild/googletest-release-1.8.0.zip
53+
URL_MD5 adfafc8512ab65fd3cf7955ef0100ff5
5454
PREFIX "${SBE_THIRDPARTY_BINARY_DIR}/gtest"
55-
BUILD_BYPRODUCTS "${SBE_THIRDPARTY_BINARY_DIR}/gtest/src/gtest-build/${CMAKE_CFG_INTDIR}/${CMAKE_STATIC_LIBRARY_PREFIX}gtest${CMAKE_STATIC_LIBRARY_SUFFIX};${SBE_THIRDPARTY_BINARY_DIR}/gtest/src/gtest-build/${CMAKE_CFG_INTDIR}/${CMAKE_STATIC_LIBRARY_PREFIX}gtest_main${CMAKE_STATIC_LIBRARY_SUFFIX}"
55+
BUILD_BYPRODUCTS "${SBE_THIRDPARTY_BINARY_DIR}/gtest/src/gtest-build/googlemock/${CMAKE_CFG_INTDIR}/${CMAKE_STATIC_LIBRARY_PREFIX}gtest${CMAKE_STATIC_LIBRARY_SUFFIX};${SBE_THIRDPARTY_BINARY_DIR}/gtest/src/gtest-build/googlemock/${CMAKE_CFG_INTDIR}/${CMAKE_STATIC_LIBRARY_PREFIX}gtest_main${CMAKE_STATIC_LIBRARY_SUFFIX}"
5656
INSTALL_COMMAND ""
5757
LOG_CONFIGURE ON
5858
LOG_BUILD ON
@@ -62,6 +62,11 @@ if(SBE_TESTS)
6262
set(GTEST_SOURCE_DIR ${source_dir})
6363
ExternalProject_Get_Property(gtest binary_dir)
6464
set(GTEST_BINARY_DIR ${binary_dir})
65+
66+
set(GTEST_LIBS
67+
${GTEST_BINARY_DIR}/googlemock/${CMAKE_CFG_INTDIR}/${CMAKE_STATIC_LIBRARY_PREFIX}gmock${CMAKE_STATIC_LIBRARY_SUFFIX}
68+
${GTEST_BINARY_DIR}/googlemock/${CMAKE_CFG_INTDIR}/${CMAKE_STATIC_LIBRARY_PREFIX}gmock_main${CMAKE_STATIC_LIBRARY_SUFFIX}
69+
)
6570
endif()
6671

6772
find_package(Threads)
@@ -123,7 +128,8 @@ set(CODEC_PERF_SCHEMA_DIR "${CMAKE_CURRENT_SOURCE_DIR}/sbe-benchmarks/src/main/r
123128
set(CODEC_EXAMPLES_SCHEMA_DIR "${CMAKE_CURRENT_SOURCE_DIR}/sbe-samples/src/main/resources")
124129

125130
include_directories(
126-
${GTEST_SOURCE_DIR}/include
131+
${GTEST_SOURCE_DIR}/googletest/include
132+
${GTEST_SOURCE_DIR}/googlemock/include
127133
${CMAKE_CURRENT_SOURCE_DIR}/sbe-tool/src/main/cpp
128134
${CODEC_TARGET_DIR}
129135
)
1.51 MB
Binary file not shown.

sbe-tool/src/test/cpp/CMakeLists.txt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,6 @@
1414
# limitations under the License.
1515
#
1616

17-
set(GTEST_LIBS
18-
${GTEST_BINARY_DIR}/${CMAKE_CFG_INTDIR}/${LIBPREFIX}gtest${LIBSUFFIX}
19-
${GTEST_BINARY_DIR}/${CMAKE_CFG_INTDIR}/${LIBPREFIX}gtest_main${LIBSUFFIX}
20-
)
21-
2217
function(sbe_test name)
2318
add_executable("${name}" "${name}.cpp")
2419
target_link_libraries("${name}" sbe ${GTEST_LIBS} ${CMAKE_THREAD_LIBS_INIT})
-1.11 MB
Binary file not shown.

0 commit comments

Comments
 (0)