Skip to content

Commit a482d9a

Browse files
committed
feat: change redis container hostname with env
1 parent 46ee74a commit a482d9a

File tree

5 files changed

+14
-4
lines changed

5 files changed

+14
-4
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ All customization options (use with caution):
113113
| Variable | Flag | Default |
114114
| -------- | ---- | ------- |
115115
| `REDIS_DOCKER_IMAGE` | `--redis-docker-image` | `redis:7` |
116+
| `REDIS_HOSTNAME` | `--redis-hostname` | `redis` |
116117
| `REDIS_OPTIMIZED` | `--redis-optimized` | `false` (`true`/`false`) |
117118

118119
## Credits

commands/host/redis-backend

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,11 @@ function optimize_config() {
4444
ddev dotenv set .ddev/.env.redis --redis-optimized=true
4545
}
4646

47+
function change_hostname() {
48+
[[ "${REDIS_HOSTNAME:-}" == "" ]] && return
49+
ddev dotenv set .ddev/.env.redis --redis-hostname="$REDIS_HOSTNAME"
50+
}
51+
4752
function cleanup() {
4853
rm -f "$DDEV_APPROOT/.ddev/.env.redis"
4954
rm -rf "$DDEV_APPROOT/.ddev/redis/"
@@ -82,10 +87,12 @@ case "$REDIS_DOCKER_IMAGE" in
8287
valkey)
8388
NAME="Valkey 8"
8489
REDIS_DOCKER_IMAGE="valkey/valkey:8"
90+
REDIS_HOSTNAME="valkey"
8591
;;
8692
valkey-alpine)
8793
NAME="Valkey 8 Alpine"
8894
REDIS_DOCKER_IMAGE="valkey/valkey:8-alpine"
95+
REDIS_HOSTNAME="valkey"
8996
;;
9097
""|--help|-h)
9198
show_help
@@ -99,6 +106,7 @@ esac
99106
check_docker_image
100107
cleanup
101108
optimize_config
109+
change_hostname
102110
use_docker_image
103111

104112
echo

commands/redis/redis-cli

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
## Aliases: redis
88

99
if [ -f /etc/redis/conf/security.conf ]; then
10-
redis-cli -p 6379 -h redis -a redis --no-auth-warning $@
10+
redis-cli -p 6379 -h "${REDIS_HOSTNAME:-redis}" -a redis --no-auth-warning $@
1111
else
12-
redis-cli -p 6379 -h redis $@
12+
redis-cli -p 6379 -h "${REDIS_HOSTNAME:-redis}" $@
1313
fi

commands/redis/redis-flush

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
## Example: "ddev redis-flush"
77

88
if [ -f /etc/redis/conf/security.conf ]; then
9-
redis-cli -p 6379 -h redis -a redis --no-auth-warning FLUSHALL ASYNC
9+
redis-cli -p 6379 -h "${REDIS_HOSTNAME:-redis}" -a redis --no-auth-warning FLUSHALL ASYNC
1010
else
11-
redis-cli -p 6379 -h redis FLUSHALL ASYNC
11+
redis-cli -p 6379 -h "${REDIS_HOSTNAME:-redis}" FLUSHALL ASYNC
1212
fi

docker-compose.redis.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ services:
33
redis:
44
container_name: ddev-${DDEV_SITENAME}-redis
55
image: ${REDIS_DOCKER_IMAGE:-redis:7}
6+
hostname: ${REDIS_HOSTNAME:-redis}
67
# These labels ensure this service is discoverable by ddev.
78
labels:
89
com.ddev.site-name: ${DDEV_SITENAME}

0 commit comments

Comments
 (0)