Fix BigInt => u128 conversion. #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rooooooooob requested changes Aug 29, 2024
Contributor
rooooooooob left a comment
rooooooooob left a comment There was a problem hiding this comment.
Thanks for the work! I just have the one issue with the test case so we know it's working.
| }); | ||
| assert_eq!(x.as_u128(), Some(int as u128)) | ||
| } | ||
| |
Contributor
There was a problem hiding this comment.
Could you add a test case where the bits wouldn't all be uniform (i.e. not all 1's)? Maybe 462_164_030_739_157_517 or something similar could do (anything where the bytes aren't interchangeable) could work. u64::MAX here would have all the byte chunks be 1's / FFFF so wouldn't this test case have passed before the change too?
rooooooooob approved these changes Aug 31, 2024
Contributor
rooooooooob left a comment
rooooooooob left a comment There was a problem hiding this comment.
LGTM. Thanks for the contribution!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.