Revert "Bug#29291533 BASESTRING::SUBSTR() LACKS VALIDATION AND LEADS TO HEAP-OVERFLOW"

This reverts commit 50ea3a2cb8e54bdb5c1f309f991996464b3e81e6. 32bit build breaks with this commit. So, reverting the changes Change-Id: I1c9681709e37cd83bf13fd560f48d305fedf11f4

Author: dineshsuryaprakash

storage/ndb/include/util/BaseString.hpp

@@ -167,7 +167,7 @@ class BaseString {
  *
  * @param start index of first character
  * @param stop index of last character
- * @return a new string on success or a null string on failure
+ * @return a new string
  */
  BaseString substr(ssize_t start, ssize_t stop = -1) const;
 

storage/ndb/src/common/util/BaseString.cpp

@@ -341,7 +341,7 @@ BaseString::substr(ssize_t start, ssize_t stop) const
  if(stop < 0)
  stop = length();
  ssize_t len = stop-start;
- if(len <= 0 || stop > m_len)
+ if(len <= 0)
  return BaseString("");
  BaseString s;
  s.assign(m_chr+start, len);
@@ -681,10 +681,6 @@ TAPTEST(BaseString)
 OK(BaseString("hamburger").substr(3) == "burger");
 OK(BaseString("hamburger").substr(4,8) == "urge");
 OK(BaseString("smiles").substr(1,5) == "mile");
-OK(BaseString("smiles").substr(1,10) == "");
-OK(BaseString("smiles").substr(10, 1) == "");
-OK(BaseString("smiles").substr(1,1) == "");
-OK(BaseString("smiles").substr(11, 15) == "");
 OK(BaseString("012345").indexOf('2') == 2);
 OK(BaseString("hej").indexOf('X') == -1);
  }