[knowledge-store] feat: Dynamic, MMR-based traversal #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bjchambers commented Jun 3, 2024
libs/knowledge-store/ragstack_knowledge_store/knowledge_store.py Outdated Show resolved Hide resolved
bjchambers commented Jun 4, 2024
libs/knowledge-store/ragstack_knowledge_store/knowledge_store.py Outdated Show resolved Hide resolved
bjchambers commented Jun 4, 2024
libs/knowledge-store/ragstack_knowledge_store/knowledge_store.py Outdated Show resolved Hide resolved
bjchambers changed the title 
Contributor Author
| @kerinin @cbornet this should be ready for review. I left two comments about things that may be worth doing in this iteration (vectorized cosine-similarity computation and score thresholds). Otherwise, it is tested and working. Things that may be especially worth looking at:
|
cbornet reviewed Jun 6, 2024
libs/knowledge-store/ragstack_knowledge_store/knowledge_store.py Outdated Show resolved Hide resolved
This required denormalizing the `text_embedding` of target nodes into the edge, making it easier to guide traversal based on distance to a query. Also fixed a bug in keyword linking which didn't create links to old nodes with the given keyword.
nicoloboschi changed the title cbornet reviewed Jun 7, 2024
cbornet reviewed Jun 7, 2024
cbornet reviewed Jun 7, 2024
libs/knowledge-store/ragstack_knowledge_store/directed_edge_extractor.py Outdated Show resolved Hide resolved
NadirJ approved these changes Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This required denormalizing the
text_embeddingof target nodes intothe edge, making it easier to guide traversal based on distance to a
query.
Also fixed a bug in keyword linking which didn't create links to old
nodes with the given keyword.