colbert: add lint to colbert package and tests #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cbornet reviewed Mar 19, 2024
| # All query embeddings in the ColBERT documentation | ||
| # this name, EQ or Q, maps the exact name in most colBERT papers | ||
| Q = self.checkpoint.queryFromText( | ||
| queriesQ = self.checkpoint.queryFromText( |
Collaborator
There was a problem hiding this comment.
Suggested change
| queriesQ = self.checkpoint.queryFromText( | |
| queries = self.checkpoint.queryFromText( |
Member
There was a problem hiding this comment.
Is there a way to align what's the variable in the paper and doc? I think the code should reflect what the paper describes. If Q cannot used, we should at least use queriesQ or something with a Q
cbornet reviewed Mar 19, 2024
| ) | ||
| | ||
| return Q | ||
| return queriesQ |
Collaborator
There was a problem hiding this comment.
Suggested change
| return queriesQ | |
| return queries |
cbornet reviewed Mar 19, 2024
| @abstractmethod | ||
| def close(self): | ||
| """Close the store.""" | ||
| pass |
cbornet reviewed Mar 19, 2024
| self, query: str, k: Optional[int], query_maxlen: Optional[int], **kwargs | ||
| ) -> List[Document]: | ||
| """Retrieve documents from the store""" | ||
| pass |
Collaborator
| Weird. Colbert is installed but the test complains that it doesn't find the module 😕 |
zzzming approved these changes Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.