Jane Review for Vector Support #610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
| Oh I should have clarified, it's not 100% ready for review yet, I only just tested the simplest happy path, there's a ton of test cases to cover yet and proper error handling. Thanks for helping out with these tests though! |
joao-r-reis reviewed Aug 28, 2024
| public CqlVector(int dimension) | ||
| { | ||
| if (dimension < 0) | ||
| if (dimension <= 0) // C* only allows positive dimension |
Collaborator
There was a problem hiding this comment.
yeah I was planning on testing this but good to get some confirmation thanks!
Collaborator
There was a problem hiding this comment.
I'll add a check to the other ctor to make sure the provided array is not empty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I will try to add some tests :)