- Notifications
You must be signed in to change notification settings - Fork 249
CSHARP-1007 Add Guid operators for CqlFunction #587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Building the driver or building an app with the driver installed? |
| Both |
Can you clarify what you are working on? Deep changes to the driver should be discussed beforehand.
I just installed .NET 7 and I can build the driver just fine, you probably need to install an earlier version of the SDK maybe? Can you tell me which sdk versions you have installed? I also created a new Console App that targets .NET 7, installed the driver and I can build this app just fine too. |
Sure, I'm trying to drop the old .NET Core versions since they are deprecated and cleaning the csproj files.
If you set the driver to build on .NET 7 these tests would have the error that I mentioned above. Same issue when using the driver as a package and trying to use operators on MaxTimeUuid/MinTimeUuid methods |
| Ok, I understand. So we are planning on doing a platform update for the C# driver (basically adding currently supported .NET versions to the test projects and dropping the EOL ones) in the near future but this requires some effort on our jenkins infra that runs these tests. Keep in mind that we will not change the targets of the driver project itself, we will keep targeting Because of the backend work that this requires I think it would be best if you held off on making these changes for now. For the issue itself I just finished testing the following: This results in the issue you are seeing with For now I recommend applying this work around until we are ready to deliver proper support of .NET 7. This should happen sometime in the next few months. |
| I will keep this PR open until we have all the test projects and infra ready to test this PR. Again, this can take a while so it's likely that this PR will stay open for a few months. |
| Also, please sign our CLA: https://cla.datastax.com/ |
Yes, I'm aware of this.
Thanks, I will wait for the update. |
| Sorry for the huge delay but we're finally upgrading the .NET versions on our test projects and build infrastructure and I've confirmed this fix works 👍 |
joao-r-reis left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll just let CI run and will merge afterwards.
I'm working on improving the infrastructure, meanwhile, I noticed builds are failing on .NET 7 because the operators are overrided for Guid.
The build fails with the following error: