Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Commit f0f5ae2

Browse files
sirupsenerezsh
authored andcommitted
tests: add rows downloaded
1 parent 748d05e commit f0f5ae2

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

data_diff/diff_tables.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -299,6 +299,7 @@ def _bisect_and_diff_tables(self, table1, table2, level=0, max_rows=None):
299299
rows1, rows2 = self._threaded_call("get_values", [table1, table2])
300300
diff = list(diff_sets(rows1, rows2))
301301
logger.info(". " * level + f"Diff found {len(diff)} different rows.")
302+
self.stats["rows_downloaded"] = self.stats.get("rows_downloaded", 0) + max(len(rows1), len(rows2))
302303
yield from diff
303304
return
304305

tests/test_database_types.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -139,16 +139,15 @@ def test_wip_int_different(self, source_db, target_db, source_type, target_type,
139139
differ = TableDiffer(bisection_threshold=3, bisection_factor=2) # ensure we actually checksum
140140
diff = list(differ.diff_tables(self.table, self.table2))
141141
expected = []
142-
# self.assertEqual(0, differ.stats.get("rows_inspected", 0))
143-
print(diff)
144142
self.assertEqual(expected, diff)
143+
self.assertEqual(0, differ.stats.get("rows_downloaded", 0))
145144

146145
# Ensure that Python agrees with the checksum!
147146
differ = TableDiffer(bisection_threshold=1000000000)
148147
diff = list(differ.diff_tables(self.table, self.table2))
149148
expected = []
150-
# self.assertEqual(6, differ.stats.get("rows_inspected", 0))
151149
self.assertEqual(expected, diff)
150+
self.assertEqual(6, differ.stats.get("rows_downloaded", 0))
152151

153152
duration = time.time() - start
154153
print(f"source_db={source_db.__name__} target_db={target_db.__name__} source_type={source_type} target_type={target_type} duration={round(duration * 1000, 2)}ms")

0 commit comments

Comments
 (0)