Base optimizer_hints throws NotImplementedError

Author: RoderickJDunn

sqeleton/databases/base.py

@@ -168,8 +168,8 @@ def current_timestamp(self) -> str:
  def explain_as_text(self, query: str) -> str:
  return f"EXPLAIN {query}"
 
- def optimizer_hints(self, s: str):
- return f"/*+ {s} */ "
+ def optimizer_hints(self, hints: str) -> str:
+ raise NotImplementedError(f"Optimizer hints not yet implemented in {self.__class__}")
 
  def _constant_value(self, v):
  if v is None:

sqeleton/databases/bigquery.py

@@ -137,9 +137,6 @@ def type_repr(self, t) -> str:
  def set_timezone_to_utc(self) -> str:
  raise NotImplementedError()
 
- def optimizer_hints(self, hints: str) -> str:
- raise NotImplementedError("Optimizer hints not yet implemented in bigquery")
-
 
 class BigQuery(Database):
  CONNECT_URI_HELP = "bigquery://<project>/<dataset>"

sqeleton/databases/clickhouse.py

@@ -162,9 +162,6 @@ def set_timezone_to_utc(self) -> str:
  def current_timestamp(self) -> str:
  return "now()"
 
- def optimizer_hints(self, hints: str) -> str:
- raise NotImplementedError("Optimizer hints not yet implemented in clickhouse")
-
 
 class Clickhouse(ThreadedDatabase):
  dialect = Dialect()

sqeleton/databases/databricks.py

@@ -94,8 +94,6 @@ def _convert_db_precision_to_digits(self, p: int) -> int:
  def set_timezone_to_utc(self) -> str:
  return "SET TIME ZONE 'UTC'"
 
- def optimizer_hints(self, hints: str) -> str:
- raise NotImplementedError("Optimizer hints not yet implemented in databricks")
 
 
 class Databricks(ThreadedDatabase):

sqeleton/databases/duckdb.py

@@ -136,9 +136,6 @@ def set_timezone_to_utc(self) -> str:
  def current_timestamp(self) -> str:
  return "current_timestamp"
 
- def optimizer_hints(self, hints: str) -> str:
- raise NotImplementedError("Optimizer hints not yet implemented in duckdb")
-
 
 class DuckDB(Database):
  dialect = Dialect()

sqeleton/databases/mysql.py

@@ -109,6 +109,9 @@ def type_repr(self, t) -> str:
  def explain_as_text(self, query: str) -> str:
  return f"EXPLAIN FORMAT=TREE {query}"
 
+ def optimizer_hints(self, s: str):
+ return f"/*+ {s} */ "
+
  def set_timezone_to_utc(self) -> str:
  return "SET @@session.time_zone='+00:00'"
 

sqeleton/databases/oracle.py

@@ -130,6 +130,9 @@ def constant_values(self, rows) -> str:
  def explain_as_text(self, query: str) -> str:
  raise NotImplementedError("Explain not yet implemented in Oracle")
 
+ def optimizer_hints(self, s: str):
+ return f"/*+ {s} */ "
+
  def parse_type(
  self,
  table_path: DbPath,

sqeleton/databases/postgresql.py

@@ -96,9 +96,6 @@ def set_timezone_to_utc(self) -> str:
  def current_timestamp(self) -> str:
  return "current_timestamp"
 
- def optimizer_hints(self, hints: str) -> str:
- raise NotImplementedError("Optimizer hints not yet implemented in postgresql")
-
 
 class PostgreSQL(ThreadedDatabase):
  dialect = PostgresqlDialect()

sqeleton/databases/presto.py

@@ -141,9 +141,6 @@ def set_timezone_to_utc(self) -> str:
  def current_timestamp(self) -> str:
  return "current_timestamp"
 
- def optimizer_hints(self, hints: str) -> str:
- raise NotImplementedError("Optimizer hints not yet implemented in presto")
-
 
 class Presto(Database):
  dialect = Dialect()

sqeleton/databases/redshift.py

@@ -57,8 +57,6 @@ def concat(self, items: List[str]) -> str:
  def is_distinct_from(self, a: str, b: str) -> str:
  return f"({a} IS NULL != {b} IS NULL) OR ({a}!={b})"
 
- def optimizer_hints(self, hints: str) -> str:
- raise NotImplementedError("Optimizer hints not yet implemented in redshift")
 
 class Redshift(PostgreSQL):
  dialect = Dialect()