Skip to content

Conversation

@kravets-levko
Copy link
Contributor

  1. Publish only necessary files (package.json, readme, licence, dist/, and thrift/)
  2. Automatically run build script before publishing to ensure that contents of dist/ is fresh and matches sources
  3. Remove dist/ from VCS as it's now created when needed
Copy link
Contributor

@moderakh moderakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this PR. This is great to let npm takes care of creating the files rather than manually check them in and updating them in each PR. Thanks @kravets-levko

@kravets-levko kravets-levko merged commit 31aac79 into databricks:master Jul 12, 2022
@kravets-levko kravets-levko deleted the tweak-npm-publish branch July 12, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants