Skip to content

enable cloud fetch by default #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2025
Merged

enable cloud fetch by default #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2ff487
enable cloud fetch by default
shivam2680 Apr 2, 2025
68916f1
update mocks for cf
shivam2680 Apr 2, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions connector_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ func TestNewConnector(t *testing.T) {
WithHTTPPath(httpPath),
)
expectedCloudFetchConfig := config.CloudFetchConfig{
UseCloudFetch: false,
UseCloudFetch: true,
MaxDownloadThreads: 10,
MaxFilesInMemory: 10,
MinTimeToExpiry: 0 * time.Second,
Expand Down Expand Up @@ -130,7 +130,7 @@ func TestNewConnector(t *testing.T) {
WithRetries(-1, 0, 0),
)
expectedCloudFetchConfig := config.CloudFetchConfig{
UseCloudFetch: false,
UseCloudFetch: true,
MaxDownloadThreads: 10,
MaxFilesInMemory: 10,
MinTimeToExpiry: 0 * time.Second,
Expand Down
2 changes: 1 addition & 1 deletion internal/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@ type CloudFetchConfig struct {
}

func (cfg CloudFetchConfig) WithDefaults() CloudFetchConfig {
cfg.UseCloudFetch = false
cfg.UseCloudFetch = true

if cfg.MaxDownloadThreads <= 0 {
cfg.MaxDownloadThreads = 10
Expand Down
Loading