Gulp Task Added #17
Merged
Gulp Task Added #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Added gulp/gulp.js to allow easy utilization of can-compile inside a gulpfile. Had to move the main function out of index.js and into its own file to get rid of the circular dependency. All functionality should remain the same.
Member Author
| I'm not sure that we need to put gulp.js in its own directory. Would it mess up Grunt to put it in the tasks folder? |
Restored index.js to its original state. Now must require the task directly from tasks folder. var compileGulp = require(‘can-compile/tasks/gulp.js’) Updated readme.md to match.
Contributor
| I'm not sure if it would mess with Grunt. The easiest way to avoid any issues is probably to move the |
Member Author
| Done. Works like a charm. |
I tried a few times to compile an array of files “Programmatically” until I read through the source code and found that it wasn’t intended to work that way. :)
Contributor
| Awesome! I'll get a new release out this week. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Enables really convenient syntax for using with Gulp.js. Allows for all of the same options.
Had to move the main function outside of index.js in order to avoid a circular reference. So, instead of
it is now
... where entry.js contains the same exact original function and dependencies.