Migrate from gson to jackson

Author: dacr

build.sbt

@@ -29,24 +29,27 @@ crossScalaVersions := Seq("2.13.15", "3.5.1")
 Test / fork := true // Required to avoid "logger conflict" between sbt and code tests
 
 lazy val versions = new {
- val drools = "9.44.0.Final"
- val jbpm = "1.44.1.Final"
+ val drools = "9.44.0.Final"
+ val jbpm = "1.44.1.Final"
+ val jackson = "2.18.0"
 }
 
 libraryDependencies ++= Seq(
- "org.drools" % "drools-core" % versions.drools,
- "org.drools" % "drools-xml-support" % versions.drools,
- "org.drools" % "drools-compiler" % versions.drools,
- "org.drools" % "drools-decisiontables" % versions.drools,
- "org.drools" % "drools-templates" % versions.drools,
- "org.drools" % "drools-serialization-protobuf" % versions.drools,
- "org.kie.kogito" % "jbpm-flow" % versions.jbpm,
- "org.kie.kogito" % "jbpm-bpmn2" % versions.jbpm,
- "org.slf4j" % "slf4j-api" % "2.0.16",
- "ch.qos.logback" % "logback-classic" % "1.5.8",
- "com.owlike" % "genson" % "1.6",
- "org.scala-lang.modules" %% "scala-collection-compat" % "2.12.0",
- "org.scalatest" %% "scalatest" % "3.2.19" % "test"
+ "org.drools" % "drools-core" % versions.drools,
+ "org.drools" % "drools-xml-support" % versions.drools,
+ "org.drools" % "drools-compiler" % versions.drools,
+ "org.drools" % "drools-decisiontables" % versions.drools,
+ "org.drools" % "drools-templates" % versions.drools,
+ "org.drools" % "drools-serialization-protobuf" % versions.drools,
+ "org.kie.kogito" % "jbpm-flow" % versions.jbpm,
+ "org.kie.kogito" % "jbpm-bpmn2" % versions.jbpm,
+ "org.slf4j" % "slf4j-api" % "2.0.16",
+ "ch.qos.logback" % "logback-classic" % "1.5.8",
+ "com.fasterxml.jackson.core" % "jackson-databind" % versions.jackson,
+ "com.fasterxml.jackson.datatype" % "jackson-datatype-jsr310" % versions.jackson,
+ "com.fasterxml.jackson.datatype" % "jackson-datatype-jdk8" % versions.jackson,
+ "org.scala-lang.modules" %% "scala-collection-compat" % "2.12.0",
+ "org.scalatest" %% "scalatest" % "3.2.19" % "test"
 )
 
 Test / testOptions += {

src/main/scala/fr/janalyse/droolscripting/Converters.scala

@@ -15,10 +15,12 @@
  */
 package fr.janalyse.droolscripting
 
-import java.io.File
-import java.text.SimpleDateFormat
-import java.time.format.DateTimeFormatter
+import com.fasterxml.jackson.databind.{MapperFeature, ObjectMapper}
+import com.fasterxml.jackson.databind.json.JsonMapper
+import com.fasterxml.jackson.datatype.jdk8.Jdk8Module
+import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule
 
+import java.io.File
 import org.slf4j._
 
 import scala.jdk.CollectionConverters._
@@ -27,9 +29,8 @@ import org.kie.api._
 import org.kie.api.runtime.KieSession
 import org.kie.api.time.{SessionClock, SessionPseudoClock}
 import org.kie.api.definition.`type`.FactType
-import java.util.concurrent.TimeUnit
 
-import com.owlike.genson.{Converter, GensonBuilder}
+import java.util.concurrent.TimeUnit
 import org.kie.api.runtime.rule.FactHandle
 
 
@@ -43,18 +44,28 @@ import org.kie.api.runtime.rule.FactHandle
 class DroolsEngine(kbaseName: String, drl: String, config: DroolsEngineConfig) extends RuntimeDrools {
  private val logger = org.slf4j.LoggerFactory.getLogger("DroolsEngine")
 
+// private val genson =
+// new GensonBuilder()
+// .setSkipNull(true)
+// .withConverters(
+// OffsetDateTimeConverter(),
+// ZonedDateTimeConverter(),
+// LocalDateTimeConverter(),
+// DateConverter()
+// )
+// .useClassMetadata(true)
+// .useConstructorWithArguments(false) // Take care, with true you may encounter IllegalArgumentException within asm.ClassReader
+// .create()
+
  private val genson =
- new GensonBuilder()
- .setSkipNull(true)
- .withConverters(
- OffsetDateTimeConverter(),
- ZonedDateTimeConverter(),
- LocalDateTimeConverter(),
- DateConverter()
- )
- .useClassMetadata(true)
- .useConstructorWithArguments(false) // Take care, with true you may encounter IllegalArgumentException within asm.ClassReader
- .create()
+ JsonMapper
+ .builder()
+ .enable(MapperFeature.ACCEPT_CASE_INSENSITIVE_ENUMS)
+ .addModule(new JavaTimeModule())
+ .addModule(new Jdk8Module())
+ .build()
+
+
 
  LoggerFactory.getLogger(Logger.ROOT_LOGGER_NAME) match {
  case rootLogger: ch.qos.logback.classic.Logger if config.withDroolsLogging =>
@@ -204,7 +215,7 @@ class DroolsEngine(kbaseName: String, drl: String, config: DroolsEngineConfig) e
  def insertJson(json: String, typeInfo: String): FactHandle = {
  val cl = container.getClassLoader
  val clazz = cl.loadClass(typeInfo)
- val result = genson.deserialize(json, clazz).asInstanceOf[Object]
+ val result = genson.readValue(json, clazz).asInstanceOf[Object]
  insert(result)
  }
 
@@ -233,7 +244,11 @@ class DroolsEngine(kbaseName: String, drl: String, config: DroolsEngineConfig) e
  *
  * @return json strings iterable
  */
- def getObjectsAsJson:Iterable[String] = session.getObjects().asScala.map(genson.serialize)
+ def getObjectsAsJson:Iterable[String] =
+ session
+ .getObjects()
+ .asScala
+ .map(genson.writeValueAsString)
 
  /**
  * Get all facts which have the given type or inheritate from it
@@ -253,7 +268,7 @@ class DroolsEngine(kbaseName: String, drl: String, config: DroolsEngineConfig) e
  * @return json strings iterable
  */
  def getModelInstancesAsJson(declaredType:String): Iterable[String] = {
- getModelInstances(declaredType).map(genson.serialize)
+ getModelInstances(declaredType).map(genson.writeValueAsString)
  }
 
  /**
@@ -289,7 +304,7 @@ class DroolsEngine(kbaseName: String, drl: String, config: DroolsEngineConfig) e
  * @return json string option
  */
  def getModelFirstInstanceAsJson(declaredType: String): Option[String] = {
- getModelFirstInstance(declaredType).map(genson.serialize)
+ getModelFirstInstance(declaredType).map(genson.writeValueAsString)
  }
 
  /**

src/main/scala/fr/janalyse/droolscripting/DroolsEngine.scala

@@ -147,8 +147,8 @@ class DroolsEngineJsonTest extends AnyFlatSpec with should.Matchers {
  |end
  |""".stripMargin
  val engine = DroolsEngine(drl)
- engine.insertJson("""LOW""", "test.Priority")
- engine.insertJson("""RED""", "test.Color")
+ engine.insertJson(""""LOW"""", "test.Priority")
+ engine.insertJson(""""RED"""", "test.Color")
  engine.insertJson("""{"priority":"LOW", "color":"GREEN"}""", "test.Combo")
  engine.fireAllRules()
  engine.getObjects should have size 3

src/test/scala/fr/janalyse/droolscripting/DroolsEngineJsonTest.scala

@@ -1 +1 @@
-ThisBuild / version := "1.1.1-SNAPSHOT"
+ThisBuild / version := "1.2.0-SNAPSHOT"