Quick fixes to auto anonymous upgrade (firebase#483)

Author: protocol86

FirebaseAuthUI/FUIAuth.h

@@ -204,8 +204,7 @@ __attribute__((deprecated("Instead use authUI:didSignInWithAuthDataResult:error:
 /** @property shouldAutoUpgradeAnonymousUsers
  @brief Whether to enable auto upgrading of anonymous accounts, defaults to NO.
  */
-@property(nonatomic, assign, getter=shouldAutoUpgradeAnonymousUsers) BOOL
- shouldAutoUpgradeAnonymousUsers;
+@property(nonatomic, assign, getter=shouldAutoUpgradeAnonymousUsers) BOOL autoUpgradeAnonymousUsers;
 
 /** @property privacyPolicyURL
  @brief The URL of your app's Privacy Policy. If not nil, a privacy policy notice is

FirebaseAuthUI/FUIAuthBaseViewController.m

@@ -256,14 +256,18 @@ + (void)showAlertWithTitle:(nullable NSString *)title
  [UIAlertAction actionWithTitle:actionTitle
  style:UIAlertActionStyleDefault
  handler:^(UIAlertAction *_Nonnull action) {
- actionHandler();
+ if (actionHandler) {
+ actionHandler();
+ }
  }];
  [alertController addAction:okAction];
  UIAlertAction *cancelAction =
  [UIAlertAction actionWithTitle:FUILocalizedString(kStr_Cancel)
  style:UIAlertActionStyleCancel
  handler:^(UIAlertAction * _Nonnull action) {
- cancelHandler();
+ if (cancelHandler) {
+ cancelHandler();
+ }
  }];
  [alertController addAction:cancelAction];
  [presentingViewController presentViewController:alertController animated:YES completion:nil];
@@ -299,14 +303,18 @@ + (void)showSignInAlertWithEmail:(NSString *)email
  [UIAlertAction actionWithTitle:providerSignInLabel
  style:UIAlertActionStyleDefault
  handler:^(UIAlertAction *_Nonnull action) {
- signinHandler();
+ if (signinHandler) {
+ signinHandler();
+ }
  }];
  [alertController addAction:signInAction];
  UIAlertAction *cancelAction =
  [UIAlertAction actionWithTitle:FUILocalizedString(kStr_Cancel)
  style:UIAlertActionStyleCancel
  handler:^(UIAlertAction * _Nonnull action) {
- cancelHandler();
+ if (cancelHandler) {
+ cancelHandler();
+ }
  }];
  [alertController addAction:cancelAction];
  [presentingViewController presentViewController:alertController animated:YES completion:nil];

samples/objc/FirebaseUI-demo-objc/Samples/Auth/FUIAuthViewController.m

@@ -231,7 +231,7 @@ - (IBAction)onAuthUIDelegateChanged:(UISwitch *)sender {
 
 - (IBAction)onAuthorization:(id)sender {
  if (!_auth.currentUser || _auth.currentUser.isAnonymous) {
- FUIAuth.defaultAuthUI.shouldAutoUpgradeAnonymousUsers = YES;
+ FUIAuth.defaultAuthUI.autoUpgradeAnonymousUsers = YES;
  _authUI.providers = [self getListOfIDPs];
  _authUI.signInWithEmailHidden = ![self isEmailEnabled];