Skip to content

Conversation

@2bndy5
Copy link
Collaborator

@2bndy5 2bndy5 commented Feb 28, 2024

@2bndy5 2bndy5 added the documentation Improvements or additions to documentation label Feb 28, 2024
- inputs and outputs are in a dedicated page - README and docs landing page auto-sync with MD substitutions - permissions are noted where needed (per feature) - adds pr-review-caveats doc - add examples recipes (resolves #195) - demo folder moved to docs/examples and corresponding CI adjusted
@2bndy5
Copy link
Collaborator Author

2bndy5 commented Feb 28, 2024

mkdocs-build.zip

I'd like to get the reusable workflow to upload these builds as artifacts.

@2bndy5
Copy link
Collaborator Author

2bndy5 commented Feb 28, 2024

I'd like to get the reusable workflow to upload these builds as artifacts.

done

@2bndy5 2bndy5 requested a review from shenxianpeng February 28, 2024 13:21
@2bndy5 2bndy5 linked an issue Feb 28, 2024 that may be closed by this pull request
@shenxianpeng
Copy link
Collaborator

I got '404 - Not found' when I clicked the link see our Inputs and Outputs document maybe because this PR not be merged?

@shenxianpeng
Copy link
Collaborator

I got '404 - Not found' when I clicked the link see our Inputs and Outputs document maybe because this PR not be merged?

OK. I got the docs zip file from GitHub Action artifacts

Copy link
Collaborator

@shenxianpeng shenxianpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and badge hooks are great.

@shenxianpeng
Copy link
Collaborator

shenxianpeng commented Feb 29, 2024

I was wondering if this is a feasible idea to have a link (e.g. https://cpp-linter.github.io/cpp-linter) displayed on the cpp-linter org home page with all the documentation including cpp-linter, cpp-linter-action, clang-tools-pip, etc.

Maybe it's better and easier to maintain this separation now.

@2bndy5
Copy link
Collaborator Author

2bndy5 commented Feb 29, 2024

It would be easier for me because I have to scroll down and find it in the list. We could also trade one of the pinned repos for cpp-linter/cpp-linter repo.

@2bndy5
Copy link
Collaborator Author

2bndy5 commented Feb 29, 2024

LGTM and badge hooks are great.

The version and permission badges also serve as links. 🚀

@2bndy5
Copy link
Collaborator Author

2bndy5 commented Feb 29, 2024

I setup a RTD project to build the docs in a PR. This way we don't have to download the build artifact, unzip it, and open it in a browser. Using the CI artifacts does not work on my phone.

@2bndy5 2bndy5 merged commit d4202dc into main Feb 29, 2024
@2bndy5 2bndy5 deleted the docs-overhaul branch February 29, 2024 02:37
@2bndy5
Copy link
Collaborator Author

2bndy5 commented Feb 29, 2024

@shenxianpeng I don't think the todo in https://github.com/orgs/cpp-linter/projects/5?pane=issue&itemId=21348575 is needed any longer, right?

@shenxianpeng
Copy link
Collaborator

Yes, I have moved it to Done.

@shenxianpeng
Copy link
Collaborator

I setup a RTD project to build the docs in a PR. This way we don't have to download the build artifact, unzip it, and open it in a browser. Using the CI artifacts does not work on my phone.

That's very convenient 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

3 participants