Skip to content
This repository was archived by the owner on Nov 30, 2021. It is now read-only.

Commit 2df3abd

Browse files
authored
Rpcapi fix - requires Eth namespace (#845)
* update join_network docs * add eth as default in apis * update changelog
1 parent 2294a19 commit 2df3abd

File tree

2 files changed

+22
-17
lines changed

2 files changed

+22
-17
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,11 @@ Ref: https://keepachangelog.com/en/1.0.0/
3535

3636
# Changelog
3737

38+
## Unreleased
39+
40+
### API Breaking
41+
* (eth) [\#845](https://github.com/cosmos/ethermint/pull/845) The `eth` namespace must be included in the list of API's as default to run the rpc server without error.
42+
3843
## [v0.4.1] - 2021-03-01
3944

4045
### API Breaking

rpc/apis.go

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,23 @@ func GetAPIs(clientCtx context.CLIContext, selectedApis []string, keys ...ethsec
3434

3535
var apis []rpc.API
3636

37+
apis = append(apis,
38+
rpc.API{
39+
Namespace: EthNamespace,
40+
Version: apiVersion,
41+
Service: ethAPI,
42+
Public: true,
43+
},
44+
)
45+
apis = append(apis,
46+
rpc.API{
47+
Namespace: EthNamespace,
48+
Version: apiVersion,
49+
Service: filters.NewAPI(clientCtx, backend),
50+
Public: true,
51+
},
52+
)
53+
3754
for _, api := range selectedApis {
3855
switch api {
3956
case Web3Namespace:
@@ -45,23 +62,6 @@ func GetAPIs(clientCtx context.CLIContext, selectedApis []string, keys ...ethsec
4562
Public: true,
4663
},
4764
)
48-
case EthNamespace:
49-
apis = append(apis,
50-
rpc.API{
51-
Namespace: EthNamespace,
52-
Version: apiVersion,
53-
Service: ethAPI,
54-
Public: true,
55-
},
56-
)
57-
apis = append(apis,
58-
rpc.API{
59-
Namespace: EthNamespace,
60-
Version: apiVersion,
61-
Service: filters.NewAPI(clientCtx, backend),
62-
Public: true,
63-
},
64-
)
6565
case PersonalNamespace:
6666
apis = append(apis,
6767
rpc.API{

0 commit comments

Comments
 (0)