Skip to content

Commit 38f718e

Browse files
Merge pull request #20162 from edsantiago/f39
CI VMs: bump to f39 + f38
2 parents 87dd939 + b284128 commit 38f718e

File tree

6 files changed

+8
-35
lines changed

6 files changed

+8
-35
lines changed

.cirrus.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,14 @@ env:
2626
####
2727
#### Cache-image names to test with (double-quotes around names are critical)
2828
####
29-
FEDORA_NAME: "fedora-38"
29+
FEDORA_NAME: "fedora-39β"
3030
FEDORA_AARCH64_NAME: "${FEDORA_NAME}-aarch64"
31-
PRIOR_FEDORA_NAME: "fedora-37"
31+
PRIOR_FEDORA_NAME: "fedora-38"
3232
RAWHIDE_NAME: "rawhide"
3333
DEBIAN_NAME: "debian-13"
3434

3535
# Image identifiers
36-
IMAGE_SUFFIX: "c20230816t191118z-f38f37d13"
36+
IMAGE_SUFFIX: "c20230928t004553z-f39f38d13"
3737

3838
# EC2 images
3939
FEDORA_AMI: "fedora-aws-${IMAGE_SUFFIX}"

contrib/cirrus/lib.sh

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,6 @@ PASSTHROUGH_ENV_ATSTART='CI|LANG|LC_|TEST'
103103
# List of envariable patterns which can match ANYWHERE in the name
104104
PASSTHROUGH_ENV_ANYWHERE='_NAME|_FQIN'
105105

106-
# Combine into one
107-
PASSTHROUGH_ENV_RE="(^($PASSTHROUGH_ENV_EXACT)\$)|(^($PASSTHROUGH_ENV_ATSTART))|($PASSTHROUGH_ENV_ANYWHERE)"
108-
109106
# Unsafe env. vars for display
110107
SECRET_ENV_RE='ACCOUNT|GC[EP]..|SSH|PASSWORD|SECRET|TOKEN'
111108

@@ -121,20 +118,6 @@ set +a
121118
lilto() { err_retry 8 1000 "" "$@"; } # just over 4 minutes max
122119
bigto() { err_retry 7 5670 "" "$@"; } # 12 minutes max
123120

124-
# Return a list of environment variables that should be passed through
125-
# to lower levels (tests in containers, or via ssh to rootless).
126-
# We return the variable names only, not their values. It is up to our
127-
# caller to reference values.
128-
passthrough_envars(){
129-
local envname
130-
warn "Will pass env. vars. matching the following regex:
131-
$PASSTHROUGH_ENV_RE"
132-
compgen -A variable | \
133-
grep -Ev "SETUP_ENVIRONMENT" | \
134-
grep -Ev "$SECRET_ENV_RE" | \
135-
grep -E "$PASSTHROUGH_ENV_RE"
136-
}
137-
138121
setup_rootless() {
139122
req_env_vars GOPATH GOSRC SECRET_ENV_RE
140123

contrib/cirrus/setup_environment.sh

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -156,11 +156,6 @@ case "$OS_RELEASE_ID" in
156156
# (Checked on 2023-08-08 and it's still too old: 1.1.5)
157157
# FIXME: please remove this once runc >= 1.2 makes it into debian.
158158
showrun modprobe tun
159-
160-
# TODO: move this into image build process
161-
# We need the "en_US.UTF-8" locale for the "podman logs with non ASCII log tag" tests
162-
showrun sed -i '/en_US.UTF-8/s/^#//g' /etc/locale.gen
163-
showrun locale-gen
164159
;;
165160
fedora)
166161
showrun echo "conditional setup for fedora"

test/e2e/logs_test.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -596,12 +596,13 @@ var _ = Describe("Podman logs", func() {
596596
logc := podmanTest.Podman([]string{"run", "--log-driver", "journald", "--log-opt", "tag=äöüß", ALPINE, "echo", "podman"})
597597
logc.WaitWithDefaultTimeout()
598598
Expect(logc).To(Exit(126))
599+
// FIXME-2023-09-26: conmon <2.1.8 logs to stdout; clean this up once >=2.1.8 is universal
600+
errmsg := logc.ErrorToString() + logc.OutputToString()
599601
if !IsRemote() {
600602
// Error is only seen on local client
601-
// Why does conmon log this to stdout? This must be fixed after https://github.com/containers/conmon/pull/447.
602-
Expect(logc.OutputToString()).To(Equal("conmon: option parsing failed: Invalid byte sequence in conversion input"))
603+
Expect(errmsg).To(ContainSubstring("conmon: option parsing failed: Invalid byte sequence in conversion input"))
603604
}
604-
Expect(logc.ErrorToString()).To(ContainSubstring("conmon failed: exit status 1"))
605+
Expect(errmsg).To(ContainSubstring("conmon failed: exit status 1"))
605606
})
606607

607608
It("podman logs with non ASCII log tag succeeds with proper env", func() {

test/e2e/stats_test.go

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package integration
33
import (
44
"fmt"
55
"strconv"
6-
"strings"
76
"time"
87

98
. "github.com/containers/podman/v4/test/utils"
@@ -182,9 +181,6 @@ var _ = Describe("Podman stats", func() {
182181

183182
// Regression test for #8265
184183
It("podman stats with custom memory limits", func() {
185-
if strings.Contains(podmanTest.OCIRuntime, "crun") {
186-
Skip("Test requires crun > 1.8.4")
187-
}
188184
// Run three containers. One with a memory limit. Make sure
189185
// that the limits are different and the limited one has a
190186
// lower limit.
@@ -235,9 +231,6 @@ var _ = Describe("Podman stats", func() {
235231
})
236232

237233
It("podman stats show cgroup memory limit", func() {
238-
if strings.Contains(podmanTest.OCIRuntime, "crun") {
239-
Skip("Test requires crun > 1.8.4")
240-
}
241234
ctrWithLimit := "with-limit"
242235

243236
session := podmanTest.Podman([]string{"run", "-d", "--name", ctrWithLimit, "--memory", "50m", ALPINE, "top"})

test/system/505-networking-pasta.bats

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -697,6 +697,7 @@ function teardown() {
697697
}
698698

699699
@test "podman networking with pasta(1) - TCP/IPv4 large transfer, tap" {
700+
skip "FIXME: #20170 - test hangs"
700701
pasta_test_do
701702
}
702703

0 commit comments

Comments
 (0)