Skip to content

Commit 09d148c

Browse files
authored
Fix linter issues in consumer testing code (#2051)
1 parent 4514346 commit 09d148c

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

tests/ducktape/consumer_benchmark_metrics.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -132,10 +132,10 @@ def get_summary(self) -> Dict[str, Any]:
132132

133133
# Operation metrics (generic for poll/consume)
134134
operation_error_rate = (self.operation_errors / self.operation_attempts
135-
if self.operation_attempts > 0 else 0)
136-
operation_success_rate = ((self.operation_attempts - self.operation_timeouts -
137-
self.operation_errors) / self.operation_attempts
138135
if self.operation_attempts > 0 else 0)
136+
operation_success_rate = ((self.operation_attempts - self.operation_timeouts -
137+
self.operation_errors) / self.operation_attempts
138+
if self.operation_attempts > 0 else 0)
139139

140140
# Operation latency analysis
141141
if self.operation_latencies:
@@ -282,12 +282,12 @@ def validate_consumer_metrics(metrics: Dict[str, Any], bounds: ConsumerMetricsBo
282282
messages_per_consume = metrics.get('messages_per_consume', 0)
283283
if messages_per_consume < bounds.min_messages_per_consume:
284284
violations.append(f"Messages per consume {messages_per_consume:.2f} "
285-
f"below minimum {bounds.min_messages_per_consume}")
285+
f"below minimum {bounds.min_messages_per_consume}")
286286

287287
empty_consume_rate = metrics.get('empty_consume_rate', 0)
288288
if empty_consume_rate > bounds.max_empty_consume_rate:
289289
violations.append(f"Empty consume rate {empty_consume_rate:.3f} "
290-
f"exceeds maximum {bounds.max_empty_consume_rate}")
290+
f"exceeds maximum {bounds.max_empty_consume_rate}")
291291

292292
# For poll operations, we skip batch efficiency validation since they're single-message operations
293293
is_valid = len(violations) == 0

tests/ducktape/test_consumer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
from tests.ducktape.services.kafka import KafkaClient
1111
from tests.ducktape.consumer_benchmark_metrics import (ConsumerMetricsCollector, ConsumerMetricsBounds,
12-
validate_consumer_metrics, print_consumer_metrics_report)
12+
validate_consumer_metrics, print_consumer_metrics_report)
1313
from tests.ducktape.consumer_strategy import SyncConsumerStrategy, AsyncConsumerStrategy
1414
from confluent_kafka import Producer
1515

0 commit comments

Comments
 (0)