Fix destroyOnExit default forwarding, make destroy recursive by default #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
lihaoyi changed the title destroyOnExit default forwardingdestroyOnExit default forwarding, make destroy recursive by default lihaoyi added a commit to com-lihaoyi/mill that referenced this pull request Feb 18, 2025
Pulls in com-lihaoyi/os-lib#359 from upstream to fix a problem with leaked processes causing hangs
lihaoyi added a commit to com-lihaoyi/mill that referenced this pull request Feb 19, 2025
…, use it in integration test cleanup (#4587) This attempts to fix some of the residual flakiness encountered in #4570 Somehow the recursive process termination we pulled in from upstream com-lihaoyi/os-lib#359 only works some of the time, and other times the processes get leaked. This PR extends the `serverId`-file-deleted shutdown logic we already used for client-server mode and enables it for `--no-server` mode as well. This lets us put an additional guardrail in our `IntegrationTester#close` to delete any such files, to try and force any Mill processes to terminate. Added an additional integration test to exercise this behavior Also fixed a bug in `ExampleTester` not honoring the `clientServerMode` flag, and update `testkit.test` to assert on those behaviors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
bincompatforwarders were incorrectly settingdestroyOnExit = falsewhen the default istrue, this makes them consistently passdestroyOnExit = falsewhen an explicit value is not providedos.proc.callwas forgetting to forwardshutdownGracePeriodanddestroyOnExitto the underlyingos.proc.spawnSubProcess#destroywas not destroying descendent processes. While this has always been the default, it has always been confusing, and often resulted in leaking orphan processes. This PR makes it recursively destroy child processes by default, unless passedrecursive = false.destroyOnExitand on timeout now is always recursiveDropping Scala-Native support for now due to:
Will open an issue to figure it out asynchronously