Added __ne__ for DBRefs PYTHON-440

Author: rozza

bson/binary.py

@@ -154,7 +154,8 @@ def __getnewargs__(self):
 
  def __eq__(self, other):
  if isinstance(other, Binary):
- return (self.__subtype, binary_type(self)) == (other.subtype, binary_type(other))
+ return ((self.__subtype, binary_type(self)) ==
+ (other.subtype, binary_type(other)))
  # We don't return NotImplemented here because if we did then
  # Binary("foo") == "foo" would return True, since Binary is a
  # subclass of str...

bson/dbref.py

@@ -115,13 +115,16 @@ def __repr__(self):
 
  def __eq__(self, other):
  if isinstance(other, DBRef):
- us = [self.__database, self.__collection,
- self.__id, self.__kwargs]
- them = [other.__database, other.__collection,
- other.__id, other.__kwargs]
+ us = (self.__database, self.__collection,
+ self.__id, self.__kwargs)
+ them = (other.__database, other.__collection,
+ other.__id, other.__kwargs)
  return us == them
  return NotImplemented
 
+ def __ne__(self, other):
+ return not self == other
+
  def __hash__(self):
  """Get a hash value for this :class:`DBRef`.
 

bson/objectid.py

@@ -254,7 +254,7 @@ def __eq__(self, other):
  return self.__id == other.__id
  return NotImplemented
 
- def __ne__(self,other):
+ def __ne__(self, other):
  if isinstance(other, ObjectId):
  return self.__id != other.__id
  return NotImplemented

bson/son.py

@@ -198,6 +198,9 @@ def __eq__(self, other):
  dict(self.items()) == dict(other.items()))
  return dict(self.items()) == other
 
+ def __ne__(self, other):
+ return not self == other
+
  def __len__(self):
  return len(self.keys())
 

pymongo/collection.py

@@ -150,6 +150,9 @@ def __eq__(self, other):
  return us == them
  return NotImplemented
 
+ def __ne__(self, other):
+ return not self == other
+
  @property
  def full_name(self):
  """The full name of this :class:`Collection`.

pymongo/database.py

@@ -183,6 +183,9 @@ def __eq__(self, other):
  return us == them
  return NotImplemented
 
+ def __ne__(self, other):
+ return not self == other
+
  def __repr__(self):
  return "Database(%r, %r)" % (self.__connection, self.__name)
 

pymongo/master_slave_connection.py

@@ -220,6 +220,9 @@ def __eq__(self, other):
  return us == them
  return NotImplemented
 
+ def __ne__(self, other):
+ return not self == other
+
  def __repr__(self):
  return "MasterSlaveConnection(%r, %r)" % (self.__master, self.__slaves)
 

pymongo/mongo_client.py

@@ -994,6 +994,9 @@ def __eq__(self, other):
  return us == them
  return NotImplemented
 
+ def __ne__(self, other):
+ return not self == other
+
  def __repr__(self):
  if len(self.__nodes) == 1:
  return "MongoClient(%r, %r)" % (self.__host, self.__port)

pymongo/mongo_replica_set_client.py

@@ -1264,6 +1264,9 @@ def __eq__(self, other):
  # XXX: Implement this?
  return NotImplemented
 
+ def __ne__(self, other):
+ return NotImplemented
+
  def __repr__(self):
  return "MongoReplicaSetClient(%r)" % (["%s:%d" % n
  for n in self.__hosts],)

pymongo/pool.py

@@ -86,6 +86,9 @@ def __eq__(self, other):
  # if its sock is the same as ours
  return hasattr(other, 'sock') and self.sock == other.sock
 
+ def __ne__(self, other):
+ return not self == other
+
  def __hash__(self):
  return hash(self.sock)