Skip to content

Commit f2f3c22

Browse files
authored
Fix: ContextMenu cutoff on dashboard (#3421)
* adjust isDown criteria in ContextMenu Fixes #3274 * add mcmunder as contributer
1 parent 5ed2c89 commit f2f3c22

File tree

4 files changed

+23
-5
lines changed

4 files changed

+23
-5
lines changed

.all-contributorsrc

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1512,6 +1512,16 @@
15121512
"contributions": [
15131513
"code"
15141514
]
1515+
},
1516+
{
1517+
"login": "mcmunder",
1518+
"name": "Matthias Christoph Munder",
1519+
"avatar_url": "https://avatars3.githubusercontent.com/u/5681686?v=4",
1520+
"profile": "http://mcmunder.de",
1521+
"contributions": [
1522+
"bug",
1523+
"code"
1524+
]
15151525
}
15161526
],
15171527
"contributorsPerLine": 7,

README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,9 +248,11 @@ Thanks goes to these wonderful people
248248
<td align="center"><a href="https://carloslfu.github.io"><img src="https://avatars3.githubusercontent.com/u/5993168?v=4" width="100px;" alt="Carlos Galarza"/><br /><sub><b>Carlos Galarza</b></sub></a><br /><a href="https://github.com/codesandbox/codesandbox-client/commits?author=carloslfu" title="Documentation">📖</a></td>
249249
<td align="center"><a href="https://github.com/soorajshankar"><img src="https://avatars2.githubusercontent.com/u/8408875?v=4" width="100px;" alt="soorajshankar"/><br /><sub><b>soorajshankar</b></sub></a><br /><a href="https://github.com/codesandbox/codesandbox-client/commits?author=soorajshankar" title="Code">💻</a></td>
250250
</tr>
251+
<tr>
252+
<td align="center"><a href="http://mcmunder.de"><img src="https://avatars3.githubusercontent.com/u/5681686?v=4" width="100px;" alt="Matthias Christoph Munder"/><br /><sub><b>Matthias Christoph Munder</b></sub></a><br /><a href="https://github.com/codesandbox/codesandbox-client/issues?q=author%3Amcmunder" title="Bug reports">🐛</a> <a href="https://github.com/codesandbox/codesandbox-client/commits?author=mcmunder" title="Code">💻</a></td>
253+
</tr>
251254
</table>
252255

253256
<!-- markdownlint-enable -->
254257
<!-- prettier-ignore-end -->
255-
256258
<!-- ALL-CONTRIBUTORS-LIST:END -->

packages/app/src/app/components/ContextMenu/index.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,9 @@ export class ContextMenu extends React.PureComponent<Props, State> {
101101
window.addEventListener('mousedown', this.mousedownHandler);
102102
window.addEventListener('keydown', this.keydownHandler);
103103

104-
const isDown = height - event.clientY > 150;
104+
const isDown = height - event.clientY > 300;
105105
const isLeft = width - event.clientX > 200;
106+
106107
this.setState({
107108
show: true,
108109
x: event.clientX + 10,

standalone-packages/vscode-textmate/package-lock.json

Lines changed: 8 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)