feat: implement S3 integration for storing and retrieving digest files #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
MickaelCa force-pushed the feat/add-s3-upload-of-ingest branch from 0c9ef62 to f94bbf9 Compare 
ix-56h requested changes Jul 20, 2025
MickaelCa force-pushed the feat/add-s3-upload-of-ingest branch from 46e5acb to 10ef67d Compare 
cyclotruc reviewed Jul 21, 2025
MickaelCa force-pushed the feat/add-s3-upload-of-ingest branch from 46b40ea to 85ff2ce Compare 
MickaelCa force-pushed the feat/add-s3-upload-of-ingest branch from 3361419 to aa21a74 Compare 
| ⚙️ Preview environment was undeployed. |
filipchristiansen force-pushed the feat/add-s3-upload-of-ingest branch from e8a23bf to 416254c Compare ix-56h previously approved these changes Jul 25, 2025
MickaelCa dismissed ix-56h’s stale review still not working in PR env with aws s3
NicolasIRAGNE requested changes Jul 25, 2025
There was a problem hiding this comment.
A few points
- S3_DIRECTORY_PREFIX is ignored when retrieving
- the ingest file name should be user-repo.txt (like we have today) i think
- when we do
# Extract source from URL or default to "unknown" git_source = { "github.com": "github", "gitlab.com": "gitlab", "bitbucket.org": "bitbucket", }.get(hostname, "unknown") can't we just do raw hostname/... ? eg /github.com/blablabla
kinda like what golang does
MickaelCa force-pushed the feat/add-s3-upload-of-ingest branch from 596eb7c to c022cfb Compare 
| LGTM |
NicolasIRAGNE approved these changes Jul 26, 2025
NicolasIRAGNE approved these changes Jul 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/coderamp-labs/issue-board/issues/13