Merge pull request #56 from coder/brett/improve-lint

chore: fix lint issues and add ci workflow

Author: brettkolodny

.github/workflows/ci.yaml

@@ -7,6 +7,27 @@ on:
  branches: [ main ]
 
 jobs:
+ lint:
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v4
+
+ - name: Setup Node.js
+ uses: actions/setup-node@v4
+ with:
+ node-version: '20'
+
+ - name: Setup pnpm
+ uses: pnpm/action-setup@v4
+
+ - name: Install dependencies
+ run: pnpm install
+
+ - name: Lint
+ run: pnpm run lint
+
  test:
  runs-on: ubuntu-latest
 

.knip.jsonc

@@ -0,0 +1,13 @@
+{
+"$schema": "https://unpkg.com/knip@5/schema.json",
+"entry": ["./src/client/index.tsx", "./src/server/index.tsx"],
+"project": ["./src/**/*.ts", "./src/**/*.tsx"],
+"ignore": [
+"**/gen/*",
+// Since components are vendored from coder/coder it would be a pain to have
+// to fix lint issues every time we update the components here by copying the
+// new ones in.
+"./src/client/components/*"
+]
+}
+

biome.jsonc

@@ -5,7 +5,16 @@
 "clientKind": "git"
 },
 "files": {
-"includes": ["**/*.config.ts", "src/**/*", "!src/client/gen/types.ts","!pnpm-lock.yaml"],
+"includes": [
+"**/*.config.ts",
+"src/**/*",
+"!src/client/gen/types.ts",
+"!pnpm-lock.yaml",
+// Since components are vendored from coder/coder it would be a pain to have
+// to fix lint issues every time we update the components here by copying the
+// new ones in.
+"!src/client/components/*"
+],
 "ignoreUnknown": true
 },
 "linter": {
@@ -63,5 +72,6 @@
 }
 }
 },
-"$schema": "https://biomejs.dev/schemas/2.1.1/schema.json"
+"$schema": "https://biomejs.dev/schemas/2.1.4/schema.json"
 }
+

eslint.config.js

@@ -6,17 +6,17 @@
  "scripts": {
  "dev": "vite",
  "build": "tsc -b && vite build && vite build --mode=client",
- "lint": "eslint .",
+ "lint": "pnpm run lint:biome && pnpm run lint:knip && pnpm run lint:circular-dep",
+ "lint:biome": "pnpm biome lint --error-on-warnings .",
+ "lint:knip": "pnpm knip",
+ "lint:circular-dep": "pnpm dpdm --no-tree --no-warning -T ./src/client/index.tsx && pnpm dpdm --no-tree --no-warning -T ./src/server/index.tsx",
  "preview": "vite preview",
  "test": "vitest",
  "test:ui": "vitest --ui",
  "test:run": "vitest run",
- "test:coverage": "vitest run --coverage",
  "test:watch": "vitest watch"
  },
  "dependencies": {
- "@fontsource-variable/inter": "^5.2.5",
- "@fontsource/dm-mono": "^5.2.5",
  "@hono/valibot-validator": "^0.5.2",
  "@microlink/react-json-view": "^1.26.2",
  "@monaco-editor/react": "^4.7.0",
@@ -33,9 +33,6 @@
  "@radix-ui/react-tooltip": "^1.2.7",
  "@tailwindcss/typography": "^0.5.16",
  "@tanstack/react-form": "^1.12.4",
- "@tanstack/valibot-form-adapter": "^0.42.1",
- "@universal-middleware/core": "^0.4.7",
- "@universal-middleware/hono": "^0.4.12",
  "@vercel/blob": "^1.1.1",
  "class-variance-authority": "^0.7.1",
  "clsx": "^2.1.1",
@@ -46,49 +43,39 @@
  "monaco-editor": "^0.52.2",
  "motion": "^12.15.0",
  "nanoid": "^5.1.5",
- "prismjs": "^1.30.0",
  "react": "^19.1.0",
  "react-dom": "^19.1.0",
  "react-markdown": "^10.1.0",
  "react-resizable-panels": "^3.0.2",
  "react-router": "^7.6.1",
- "react-simple-code-editor": "^0.14.1",
  "react-syntax-highlighter": "^15.6.1",
  "remark-gfm": "^4.0.1",
  "tailwind-merge": "^3.3.0",
  "tailwindcss-animate": "^1.0.7",
  "valibot": "^1.1.0",
- "yup": "^1.6.1",
- "zustand": "^5.0.5"
+ "yup": "^1.6.1"
  },
  "devDependencies": {
- "@biomejs/biome": "2.1.1",
- "@eslint/js": "^9.25.0",
+ "@biomejs/biome": "^2.1.4",
  "@hono/vite-dev-server": "^0.19.1",
- "@testing-library/jest-dom": "^6.6.4",
  "@testing-library/react": "^16.3.0",
  "@types/lodash": "^4.17.17",
  "@types/node": "^22.15.21",
- "@types/prismjs": "^1.26.5",
  "@types/react": "^19.1.2",
  "@types/react-dom": "^19.1.2",
  "@types/react-syntax-highlighter": "^15.5.13",
  "@vitejs/plugin-basic-ssl": "^2.0.0",
  "@vitejs/plugin-react": "^4.4.1",
  "autoprefixer": "^10.4.21",
- "eslint": "^9.25.0",
- "eslint-plugin-react-hooks": "^5.2.0",
- "eslint-plugin-react-refresh": "^0.4.19",
- "globals": "^16.0.0",
+ "dpdm": "^3.14.0",
  "happy-dom": "^18.0.1",
+ "knip": "^5.62.0",
  "postcss": "^8.5.3",
  "tailwindcss": "3",
  "typescript": "~5.8.3",
- "typescript-eslint": "^8.30.1",
- "vercel": "^42.3.0",
  "vite": "^6.3.5",
- "vite-plugin-vercel": "^9.0.7",
  "vitest": "^3.2.4"
  },
  "packageManager": "pnpm@10.14.0+sha512.ad27a79641b49c3e481a16a805baa71817a04bbe06a38d17e60e2eaee83f6a146c6a688125f5792e48dd5ba30e7da52a5cda4c3992b9ccf333f9ce223af84748"
-}
+}
+