Use OS-agnostic relpaths in dev configurations #1617
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ParkerM force-pushed the fix/sample-resource-relpaths branch from b3d8e76 to a858d50 Compare 
Member
Member
ParkerM force-pushed the fix/sample-resource-relpaths branch from a858d50 to 73dea54 Compare 
Author
| Rebase has been pushed, thanks @jonashackt! |
…-relpaths * origin/master: Add retry on failing subscription (codecentric#1697) chore(deps): update dependency pl.project13.maven:git-commit-id-plugin to v4.0.4 (codecentric#1663) chore(deps): update dependency com.puppycrawl.tools:checkstyle to v8.41.1 (codecentric#1648) Fix for codecentric#1638 (codecentric#1673) Improve npm ci build times (see codecentric#1688) (codecentric#1689) Improved execution of grouped assertions (codecentric#1674) Use maven repo cache during publish snapshots (codecentric#1687) chore(deps): update metcalfc/changelog-generator action to v1 (codecentric#1669) chore(deps): update dependency org.codehaus.mojo:flatten-maven-plugin to v1.2.7 (codecentric#1686) Fix file formating by applying spring-javaformat:apply (codecentric#1685) Cache mvn repo in main build (see codecentric#1677 ) (codecentric#1678) Added support DingTalk notifier. (codecentric#1653) Simplify some code (codecentric#1670) Bugfix/1646 (codecentric#1661) Upgrade spring cloud dependencies (codecentric#1645) chore(deps): update dependency com.github.eirslett:frontend-maven-plugin to v1.11.2 (codecentric#1635) chore(deps): update spring boot to v2.4.3 (codecentric#1637) Bump version to 2.4.1-SNAPSHOT chore(deps): update testcontainers.version to v1.15.2 (codecentric#1629)
Codecov Report
@@ Coverage Diff @@ ## master #1617 +/- ## ============================================ + Coverage 83.59% 83.61% +0.02% - Complexity 1212 1213 +1 ============================================ Files 152 152 Lines 3559 3559 Branches 251 251 ============================================ + Hits 2975 2976 +1 + Misses 455 454 -1 Partials 129 129
Continue to review full report at Codecov.
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Running a local development build as described in Running Spring Boot Admin Server for development doesn't work as expected on Windows, with most assets returning a 404.
I suspect the cause is the absolute paths in the form of
@project.basedir@/../../spring-boot-admin-server-ui/target/dist/, which resolve to something weird likeC:\\Users\\me\\<projectdir>\\../../spring-boot-admin-server-ui/target/dist/.Using relative paths fixes the issue on Windows, and does not seem to affect existing behavior in *nix (tested on Windows 10 and Ubuntu 20.10).