refactor(migrations): switch from esbuild to Rollup for schematics bundling (angular#57602)

Replaces esbuild with Rollup for bundling schematics to support code splitting, as esbuild does not handle code splitting when targeting CommonJS modules. **Before:** ``` du -sh dist/bin/packages/core/npm_package/schematics 7.7M dist/bin/packages/core/npm_package/schematics ``` **After:** ``` du -sh dist/bin/packages/core/npm_package/schematics 3.1M dist/bin/packages/core/npm_package/schematics ``` PR Close angular#57602

Author: alan-agius4

packages/core/schematics/BUILD.bazel

@@ -1,4 +1,5 @@
 load("//tools:defaults.bzl", "pkg_npm")
+load("@npm//@bazel/rollup:index.bzl", "rollup_bundle")
 
 exports_files([
  "tsconfig.json",
@@ -20,9 +21,33 @@ pkg_npm(
  validate = False,
  visibility = ["//packages/core:__pkg__"],
  deps = [
- "//packages/core/schematics/ng-generate/control-flow-migration:bundle",
- "//packages/core/schematics/ng-generate/inject-migration:bundle",
- "//packages/core/schematics/ng-generate/route-lazy-loading:bundle",
- "//packages/core/schematics/ng-generate/standalone-migration:bundle",
+ ":bundles",
+ ],
+)
+
+rollup_bundle(
+ name = "bundles",
+ config_file = ":rollup.config.js",
+ entry_points = {
+ "//packages/core/schematics/ng-generate/control-flow-migration:index.ts": "control-flow-migration",
+ "//packages/core/schematics/ng-generate/inject-migration:index.ts": "inject-migration",
+ "//packages/core/schematics/ng-generate/route-lazy-loading:index.ts": "route-lazy-loading",
+ "//packages/core/schematics/ng-generate/standalone-migration:index.ts": "standalone-migration",
+ },
+ format = "cjs",
+ link_workspace_root = True,
+ output_dir = True,
+ sourcemap = "false",
+ visibility = [
+ "//packages/core/schematics/test:__pkg__",
+ ],
+ deps = [
+ "//packages/core/schematics/ng-generate/control-flow-migration",
+ "//packages/core/schematics/ng-generate/inject-migration",
+ "//packages/core/schematics/ng-generate/route-lazy-loading",
+ "//packages/core/schematics/ng-generate/standalone-migration",
+ "@npm//@rollup/plugin-commonjs",
+ "@npm//@rollup/plugin-node-resolve",
+ "@npm//magic-string",
  ],
 )

packages/core/schematics/collection.json

@@ -2,34 +2,27 @@
  "schematics": {
  "standalone-migration": {
  "description": "Converts the entire application or a part of it to standalone",
- "factory": "./ng-generate/standalone-migration/bundle",
+ "factory": "./bundles/standalone-migration#migrate",
  "schema": "./ng-generate/standalone-migration/schema.json",
- "aliases": [
- "standalone"
- ]
+ "aliases": ["standalone"]
  },
  "control-flow-migration": {
  "description": "Converts the entire application to block control flow syntax",
- "factory": "./ng-generate/control-flow-migration/bundle",
+ "factory": "./bundles/control-flow-migration#migrate",
  "schema": "./ng-generate/control-flow-migration/schema.json",
- "aliases": [
- "control-flow"
- ]
+ "aliases": ["control-flow"]
  },
  "inject-migration": {
  "description": "Converts usages of constructor-based injection to the inject() function",
- "factory": "./ng-generate/inject-migration/bundle",
+ "factory": "./bundles/inject-migration#migrate",
  "schema": "./ng-generate/inject-migration/schema.json",
- "aliases": [
- "inject"
- ]
+ "aliases": ["inject"]
  },
  "route-lazy-loading-migration": {
  "description": "Updates route definitions to use lazy-loading of components instead of eagerly referencing them",
- "factory": "./ng-generate/route-lazy-loading/bundle",
+ "factory": "./bundles/route-lazy-loading#migrate",
  "schema": "./ng-generate/route-lazy-loading/schema.json",
  "aliases": ["route-lazy-loading"]
  }
  }
 }
-

packages/core/schematics/ng-generate/control-flow-migration/BUILD.bazel

@@ -1,4 +1,4 @@
-load("//tools:defaults.bzl", "esbuild_no_sourcemaps", "ts_library")
+load("//tools:defaults.bzl", "ts_library")
 
 package(
  default_visibility = [
@@ -25,15 +25,3 @@ ts_library(
  "@npm//typescript",
  ],
 )
-
-esbuild_no_sourcemaps(
- name = "bundle",
- entry_point = ":index.ts",
- external = [
- "@angular-devkit/*",
- "typescript",
- ],
- format = "cjs",
- platform = "node",
- deps = [":control-flow-migration"],
-)

packages/core/schematics/ng-generate/control-flow-migration/ifs.ts

@@ -23,7 +23,6 @@ import {
  getPlaceholder,
  hasLineBreaks,
  parseTemplate,
- PlaceholderKind,
  reduceNestingOffset,
 } from './util';
 

packages/core/schematics/ng-generate/control-flow-migration/index.ts

@@ -21,7 +21,7 @@ interface Options {
  format: boolean;
 }
 
-export default function (options: Options): Rule {
+export function migrate(options: Options): Rule {
  return async (tree: Tree, context: SchematicContext) => {
  const basePath = process.cwd();
  const pathToMigrate = normalizePath(join(basePath, options.path));

packages/core/schematics/ng-generate/control-flow-migration/migration.ts

@@ -23,10 +23,8 @@ import {
 import {
  canRemoveCommonModule,
  formatTemplate,
- parseTemplate,
  processNgTemplates,
  removeImports,
- validateI18nStructure,
  validateMigratedTemplate,
 } from './util';
 

packages/core/schematics/ng-generate/inject-migration/BUILD.bazel

@@ -1,4 +1,4 @@
-load("//tools:defaults.bzl", "esbuild_no_sourcemaps", "ts_library")
+load("//tools:defaults.bzl", "ts_library")
 
 package(
  default_visibility = [
@@ -24,15 +24,3 @@ ts_library(
  "@npm//typescript",
  ],
 )
-
-esbuild_no_sourcemaps(
- name = "bundle",
- entry_point = ":index.ts",
- external = [
- "@angular-devkit/*",
- "typescript",
- ],
- format = "cjs",
- platform = "node",
- deps = [":inject-migration"],
-)

packages/core/schematics/ng-generate/inject-migration/index.ts

@@ -18,7 +18,7 @@ interface Options extends MigrationOptions {
  path: string;
 }
 
-export default function (options: Options): Rule {
+export function migrate(options: Options): Rule {
  return async (tree: Tree) => {
  const basePath = process.cwd();
  const pathToMigrate = normalizePath(join(basePath, options.path));

packages/core/schematics/ng-generate/route-lazy-loading/BUILD.bazel

@@ -1,4 +1,4 @@
-load("//tools:defaults.bzl", "esbuild_no_sourcemaps", "ts_library")
+load("//tools:defaults.bzl", "ts_library")
 
 package(
  default_visibility = [
@@ -26,15 +26,3 @@ ts_library(
  "@npm//typescript",
  ],
 )
-
-esbuild_no_sourcemaps(
- name = "bundle",
- entry_point = ":index.ts",
- external = [
- "@angular-devkit/*",
- "typescript",
- ],
- format = "cjs",
- platform = "node",
- deps = [":route-lazy-loading"],
-)

packages/core/schematics/ng-generate/route-lazy-loading/index.ts

@@ -20,7 +20,7 @@ interface Options {
  path: string;
 }
 
-export default function (options: Options): Rule {
+export function migrate(options: Options): Rule {
  return async (tree, context) => {
  const {buildPaths} = await getProjectTsConfigPaths(tree);
  const basePath = process.cwd();