refactor(service-worker): refactored code to remove useless code (angular#47255)

- Removes useless code in `generator.ts` and `module.ts` in service-workers - Uses inline variables to return values from functions PR Close angular#47255

Author: vyom1611

packages/service-worker/config/src/generator.ts

@@ -144,14 +144,13 @@ function globListToMatcher(globs: string[]): (file: string) => boolean {
 }
 
 function matches(file: string, patterns: {positive: boolean, regex: RegExp}[]): boolean {
- const res = patterns.reduce((isMatch, pattern) => {
+ return patterns.reduce((isMatch, pattern) => {
  if (pattern.positive) {
  return isMatch || pattern.regex.test(file);
  } else {
  return isMatch && !pattern.regex.test(file);
  }
  }, false);
- return res;
 }
 
 function urlToRegex(url: string, baseHref: string, literalQuestionMark?: boolean): string {

packages/service-worker/src/module.ts

@@ -80,7 +80,7 @@ export const SCRIPT = new InjectionToken<string>('NGSW_REGISTER_SCRIPT');
 export function ngswAppInitializer(
  injector: Injector, script: string, options: SwRegistrationOptions,
  platformId: string): Function {
- const initializer = () => {
+ return () => {
  if (!(isPlatformBrowser(platformId) && ('serviceWorker' in navigator) &&
  options.enabled !== false)) {
  return;
@@ -132,7 +132,6 @@ export function ngswAppInitializer(
  navigator.serviceWorker.register(script, {scope: options.scope})
  .catch(err => console.error('Service worker registration failed with:', err))));
  };
- return initializer;
 }
 
 function delayWithTimeout(timeout: number): Observable<unknown> {