fix workspace toggling

Author: Thomas Stromberg

Makefile

@@ -2,6 +2,10 @@
 deploy:
 ./hacks/deploy.sh
 
+.PHONY: test
+test:
+node --test assets/workspace.test.js
+
 
 # BEGIN: lint-install .
 # http://github.com/codeGROOVE-dev/lint-install

assets/README.tests.md

@@ -0,0 +1,62 @@
+# Automated Tests
+
+## Running Tests
+
+```bash
+make test
+```
+
+Or directly with Node.js:
+
+```bash
+node --test assets/workspace.test.js
+```
+
+## Test Coverage
+
+### `workspace.test.js`
+Tests for the workspace module (`assets/workspace.js`):
+
+- **currentWorkspace()**: Validates workspace detection from subdomain
+ - Base domain returns `null`
+ - Reserved subdomains (www, api, etc.) return `null`
+ - Org subdomains return the org name
+ - Localhost returns `null`
+
+- **hiddenOrgs()**: Validates reading hidden organizations from cookies
+ - Returns empty array when no preferences exist
+ - Reads from workspace-specific cookies
+ - Handles both personal and org workspaces
+
+- **setHiddenOrgs()**: Validates setting hidden organizations
+ - Creates workspace-specific cookies
+ - Handles empty arrays
+ - Works for both personal and org workspaces
+
+- **toggleOrgVisibility()**: Validates toggling org visibility
+ - Adds org when not present
+ - Removes org when present
+ - Works correctly across multiple toggles
+
+- **initializeDefaults()**: Validates default behavior for org workspaces
+ - Hides personal account PRs by default in org workspaces
+ - Does NOT set defaults in personal workspace
+ - Does NOT override existing preferences
+ - Requires username cookie to be set
+ - Maintains independent preferences per workspace
+
+- **Integration tests**: Validates full workflow scenarios
+ - Users can override defaults by toggling
+ - Preferences persist across page reloads
+ - Repeated toggles work correctly (idempotency)
+ - No duplicate orgs from rapid clicking (regression test)
+
+## Test Framework
+
+Tests use Node.js built-in test runner (available in Node.js 18+). No external dependencies required.
+
+The tests create a mock DOM environment with:
+- `MockDocument`: Simulates `document` with cookie storage
+- `MockWindow`: Simulates `window` with location/hostname
+
+This allows testing browser-specific code in a Node.js environment.

assets/app.js

@@ -425,6 +425,10 @@ const App = (() => {
  // Load current user
  const loadCurrentUser = async () => {
  state.currentUser = await Auth.loadCurrentUser();
+ // Store username in cookie for workspace module
+ if (state.currentUser && state.currentUser.login) {
+ setCookie("username", state.currentUser.login, 365);
+ }
  };
 
  // GitHub API wrapper that uses Auth module
@@ -909,6 +913,9 @@ const App = (() => {
  updateSearchInputVisibility();
  await loadCurrentUser();
 
+ // Initialize workspace defaults after user is loaded
+ Workspace.initializeDefaults();
+
  // If at root URL, redirect to user's page
  if (!urlContext && state.currentUser) {
  window.location.href = `/u/${state.currentUser.login}`;

assets/user.js

@@ -996,8 +996,7 @@ export const User = (() => {
  const newHiddenOrgs = Workspace.hiddenOrgs();
  console.log("[populateOrgFilters] After toggle, hidden orgs:", newHiddenOrgs);
 
- // Refresh the menu and PR sections
- populateOrgFilters(state);
+ // Refresh PR sections (which also refreshes the menu)
  updatePRSections(state);
  });
  });

assets/workspace.js

@@ -60,6 +60,10 @@ export const Workspace = (() => {
  const cookieName = `hidden_orgs_${workspace}`;
  const cookieValue = JSON.stringify(orgs);
 
+ console.log(`[Workspace.setHiddenOrgs] Workspace: ${workspace}`);
+ console.log(`[Workspace.setHiddenOrgs] Cookie name: ${cookieName}`);
+ console.log(`[Workspace.setHiddenOrgs] Cookie value: ${cookieValue}`);
+
  // Cookie size limit check (4KB is typical browser limit)
  // Allow some overhead for cookie name and attributes
  const maxCookieSize = 3800; // Conservative limit
@@ -79,23 +83,33 @@ export const Workspace = (() => {
  expires.setTime(expires.getTime() + 365 * 24 * 60 * 60 * 1000);
  const isSecure = window.location.protocol === "https:";
  const securePart = isSecure ? ";Secure" : "";
- document.cookie = `${cookieName}=${cookieValue};expires=${expires.toUTCString()};path=/;domain=.${BASE_DOMAIN};SameSite=Lax${securePart}`;
+ const cookieString = `${cookieName}=${cookieValue};expires=${expires.toUTCString()};path=/;domain=.${BASE_DOMAIN};SameSite=Lax${securePart}`;
+ console.log(`[Workspace.setHiddenOrgs] Setting cookie: ${cookieString}`);
+ document.cookie = cookieString;
+ console.log(`[Workspace.setHiddenOrgs] document.cookie after set:`, document.cookie);
  };
 
  // Toggle org visibility
  const toggleOrgVisibility = (org) => {
+ console.log(`[Workspace.toggleOrgVisibility] Toggling: ${org}`);
  const hidden = hiddenOrgs();
+ console.log(`[Workspace.toggleOrgVisibility] Current hidden orgs:`, hidden);
  const index = hidden.indexOf(org);
+ console.log(`[Workspace.toggleOrgVisibility] Index of ${org}:`, index);
 
  if (index === -1) {
  // Hide the org
+ console.log(`[Workspace.toggleOrgVisibility] Adding ${org} to hidden list`);
  hidden.push(org);
  } else {
  // Show the org
+ console.log(`[Workspace.toggleOrgVisibility] Removing ${org} from hidden list`);
  hidden.splice(index, 1);
  }
 
+ console.log(`[Workspace.toggleOrgVisibility] New hidden list:`, hidden);
  setHiddenOrgs(hidden);
+ console.log(`[Workspace.toggleOrgVisibility] After setHiddenOrgs, reading back:`, hiddenOrgs());
  return hidden;
  };
 
@@ -104,6 +118,27 @@ export const Workspace = (() => {
  return hiddenOrgs().includes(org);
  };
 
+ // Initialize default hidden orgs for org-based workspaces
+ // In org workspaces, hide personal account PRs by default, show all orgs
+ const initializeDefaults = () => {
+ const workspace = currentWorkspace();
+ const username = getCookie("username");
+
+ // Only initialize defaults for org workspaces (not personal workspace)
+ if (!workspace || !username) return;
+
+ const cookieName = `hidden_orgs_${workspace}`;
+ const existingCookie = getCookie(cookieName);
+
+ // Only set defaults if no preference exists yet
+ if (existingCookie === null) {
+ console.log(`[Workspace] Initializing defaults for org workspace: ${workspace}`);
+ console.log(`[Workspace] Hiding personal account: ${username}`);
+ // Hide the user's personal GitHub account by default
+ setHiddenOrgs([username]);
+ }
+ };
+
  // Switch workspace (redirect to different subdomain, preserving current path)
  const switchWorkspace = (org) => {
  const protocol = window.location.protocol;
@@ -150,6 +185,7 @@ export const Workspace = (() => {
  isOrgHidden,
  switchWorkspace,
  username,
+ initializeDefaults,
  };
  console.log("[Workspace Module] Exports:", workspaceExports);
  return workspaceExports;