[java][bidi] Add constructor parameter for commands without a response

Author: pujagani

java/src/org/openqa/selenium/bidi/Command.java

@@ -31,6 +31,7 @@ public class Command<X> {
  private final String method;
  private final Map<String, Object> params;
  private final Function<JsonInput, X> mapper;
+ private final boolean sendsResponse;
 
  public Command(String method, Map<String, Object> params) {
  this(method, params, Object.class);
@@ -41,9 +42,14 @@ public Command(String method, Map<String, Object> params, Type typeOfX) {
  }
 
  public Command(String method, Map<String, Object> params, Function<JsonInput, X> mapper) {
+ this(method, params, mapper, true);
+ }
+
+ public Command(String method, Map<String, Object> params, Function<JsonInput, X> mapper, boolean sendsResponse) {
  this.method = Require.nonNull("Method name", method);
  this.params = ImmutableMap.copyOf(Require.nonNull("Command parameters", params));
  this.mapper = Require.nonNull("Mapper for result", mapper);
+ this.sendsResponse = sendsResponse;
  }
 
  public String getMethod() {
@@ -54,6 +60,10 @@ public Map<String, Object> getParams() {
  return params;
  }
 
+ public boolean getSendsResponse() {
+ return sendsResponse;
+ }
+
  Function<JsonInput, X> getMapper() {
  return mapper;
  }

java/src/org/openqa/selenium/bidi/Connection.java

@@ -108,20 +108,23 @@ public <X> CompletableFuture<X> send(Command<X> command) {
  long id = NEXT_ID.getAndIncrement();
 
  CompletableFuture<X> result = new CompletableFuture<>();
- methodCallbacks.put(id, NamedConsumer.of(command.getMethod(), inputOrException -> {
- if (inputOrException.isRight()) {
- try {
- X value = command.getMapper().apply(inputOrException.right());
- result.complete(value);
- } catch (Exception e) {
- LOG.log(Level.WARNING, String.format("Unable to map result for %s", command.getMethod()),
- e);
- result.completeExceptionally(e);
+ if (command.getSendsResponse()) {
+ methodCallbacks.put(id, NamedConsumer.of(command.getMethod(), inputOrException -> {
+ if (inputOrException.isRight()) {
+ try {
+ X value = command.getMapper().apply(inputOrException.right());
+ result.complete(value);
+ } catch (Exception e) {
+ LOG.log(Level.WARNING,
+ String.format("Unable to map result for %s", command.getMethod()),
+ e);
+ result.completeExceptionally(e);
+ }
+ } else {
+ result.completeExceptionally(inputOrException.left());
  }
- } else {
- result.completeExceptionally(inputOrException.left());
- }
- }));
+ }));
+ }
 
  ImmutableMap.Builder<String, Object> serialized = ImmutableMap.builder();
  serialized.put("id", id);
@@ -135,6 +138,10 @@ public <X> CompletableFuture<X> send(Command<X> command) {
  LOG.log(getDebugLogLevel(), () -> String.format("-> %s", json));
  socket.sendText(json);
 
+ if (!command.getSendsResponse()) {
+ result.complete(null);
+ }
+
  return result;
  }