Improve websocket connection stability

When driver/browser are forcefully closed, we don't want to raise from the websocket thread and gracefully stop it instead.

Author: p0deje

rb/lib/selenium/webdriver/common/websocket_connection.rb

@@ -22,6 +22,11 @@
 module Selenium
  module WebDriver
  class WebSocketConnection
+ CONNECTION_ERRORS = [
+ Errno::ECONNRESET, # connection is aborted (browser process was killed)
+ Errno::EPIPE # broken pipe (browser process was killed)
+ ].freeze
+
  RESPONSE_WAIT_TIMEOUT = 30
  RESPONSE_WAIT_INTERVAL = 0.1
 
@@ -90,6 +95,8 @@ def attach_socket_listener
  end
  end
  end
+ rescue *CONNECTION_ERRORS
+ Thread.stop
  end
  end
 
@@ -122,6 +129,8 @@ def callback_thread(params)
  Thread.current.report_on_exception = true
 
  yield params
+ rescue *CONNECTION_ERRORS
+ Thread.stop
  end
  end
 

rb/spec/integration/selenium/webdriver/devtools_spec.rb

@@ -30,20 +30,21 @@ module WebDriver
  end
 
  it 'supports events' do
- callback = instance_double(Proc, call: nil)
-
- driver.devtools.page.enable
- driver.devtools.page.on(:load_event_fired) { callback.call }
- driver.navigate.to url_for('xhtmlTest.html')
- sleep 0.5
-
- expect(callback).to have_received(:call).at_least(:once)
+ expect { |block|
+ driver.devtools.page.enable
+ driver.devtools.page.on(:load_event_fired, &block)
+ driver.navigate.to url_for('xhtmlTest.html')
+ sleep 0.5
+ }.to yield_control
  end
 
  it 'propagates errors in events' do
- driver.devtools.page.enable
- driver.devtools.page.on(:load_event_fired) { raise "This is fine!" }
- expect { driver.navigate.to url_for('xhtmlTest.html') }.to raise_error(RuntimeError, "This is fine!")
+ expect {
+ driver.devtools.page.enable
+ driver.devtools.page.on(:load_event_fired) { raise "This is fine!" }
+ driver.navigate.to url_for('xhtmlTest.html')
+ sleep 0.5
+ }.to raise_error(RuntimeError, "This is fine!")
  end
 
  context 'authentication', except: {browser: %i[firefox firefox_nightly],