Stop using system-wide Python for Bazel

Instead we rely on the hermetic Python toolchain installed via https://github.com/bazelbuild/rules_python. Most of the py_* targets already work fine with it. This commit also replaces workspace_status_command so that it does not require system-wide Python installation and instead use a simple Bash script on Linux/macOS and a PowerShell script on Windows.

Author: p0deje

.bazelrc

@@ -1,6 +1,7 @@
 try-import .bazelrc.local
 
 # Ensure Windows support is accurate.
+
 startup --windows_enable_symlinks
 build --enable_runfiles
 
@@ -31,7 +32,10 @@ build --action_env=PATH
 
 # For build stamping
 
-build --workspace_status_command=scripts/build-info.py
+build --enable_platform_specific_config
+build:linux --workspace_status_command=scripts/build-info.sh
+build:macos --workspace_status_command=scripts/build-info.sh
+build:windows --workspace_status_command="powershell.exe scripts/build-info.ps1"
 
 # Make sure we get something helpful when tests fail
 

BUILD.bazel

@@ -1,7 +1,6 @@
 load("//common:browsers.bzl", "chrome_data", "firefox_data")
 load("//java:browsers.bzl", "chrome_jvm_flags", "firefox_jvm_flags")
 load("//java:defs.bzl", "artifact")
-load("@rules_python//python:defs.bzl", "py_runtime_pair")
 
 filegroup(
  name = "license",
@@ -12,29 +11,6 @@ filegroup(
  visibility = ["//visibility:public"],
 )
 
-py_runtime(
- name = "py3_runtime",
- interpreter_path = select({
- "@platforms//os:macos": "/usr/bin/python3",
- "@platforms//os:linux": "/usr/bin/python",
- "@platforms//os:windows": "C:\\Python310\\python",
- }),
- python_version = "PY3",
- stub_shebang = "#!/usr/bin/python3",
-)
-
-py_runtime_pair(
- name = "py_runtime_pair",
- py2_runtime = None,
- py3_runtime = ":py3_runtime",
-)
-
-toolchain(
- name = "py_toolchain",
- toolchain = ":py_runtime_pair",
- toolchain_type = "@rules_python//python:toolchain_type",
-)
-
 alias(
  name = "grid",
  actual = "//java/src/org/openqa/selenium/grid:executable-grid",

Rakefile

@@ -85,7 +85,7 @@ CrazyFun::Mappings::RakeMappings.new.add_all(crazy_fun)
 
 # If it looks like a bazel target, build it with bazel
 rule /\/\/.*/ do |task|
- task.out = Bazel.execute('build', %w[--workspace_status_command scripts/build-info.py], task.name)
+ task.out = Bazel.execute('build', task.name)
 end
 
 # Spoof tasks to get CI working with bazel

WORKSPACE

@@ -2,17 +2,6 @@ workspace(
  name = "selenium",
 )
 
-load("//common/private:env.bzl", "env")
-
-env(
- name = "python_version",
- env_var = ["PYTHON_VERSION"],
-)
-
-load("@python_version//:defs.bzl", "PYTHON_VERSION")
-
-register_toolchains(":py_toolchain")
-
 load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 
 http_archive(
@@ -57,7 +46,7 @@ load("@rules_python//python:repositories.bzl", "python_register_toolchains")
 
 python_register_toolchains(
  name = "python_toolchain",
- python_version = PYTHON_VERSION,
+ python_version = "3.8",
 )
 
 load("@python_toolchain//:defs.bzl", "interpreter")

py/BUILD.bazel

@@ -264,7 +264,7 @@ py_binary(
  "//common/devtools/chromium/" + n + ":js_protocol",
  ],
  outs = ["selenium/webdriver/common/devtools/" + n],
- cmd = "python3 $(location :generate) $(location //common/devtools/chromium/" + n + ":browser_protocol) $(location //common/devtools/chromium/" + n + ":js_protocol) $@",
+ cmd = "$(location :generate) $(location //common/devtools/chromium/" + n + ":browser_protocol) $(location //common/devtools/chromium/" + n + ":js_protocol) $@",
  tools = [
  ":generate",
  ],

rake_tasks/bazel/task.rb

@@ -5,7 +5,7 @@ def needed?
  end
 
  def invoke(*_args, &block)
- self.out = Bazel::execute("build", ["--workspace_status_command=\"#{py_exe} scripts/build-info.py\""], name, &block)
+ self.out = Bazel::execute("build", name, &block)
 
  block&.call(cmd_out)
  end

scripts/build-info.ps1

@@ -0,0 +1,8 @@
+$revision = (git rev-parse --short HEAD)
+$dirtyout = (git status --porcelain --untracked-files=no)
+if ($dirtyout -eq $null) {
+ $dirty = ""
+} else {
+ $dirty = "*"
+}
+echo "STABLE_GIT_REVISION $revision$dirty"

scripts/build-info.py

@@ -0,0 +1,10 @@
+#!/bin/bash
+
+revision=$(git rev-parse --short HEAD)
+if [ -n "$(git status --porcelain --untracked-files=no)" ]; then
+ dirty="*"
+else
+ dirty=""
+fi
+
+echo "STABLE_GIT_REVISION $revision$dirty"