[rb] remove references to testing firefox nightly

can still specify desired browser by setting path in ENV['FIREFOX_BINARY']

Author: titusfortner

README.md

@@ -237,7 +237,7 @@ _browsername_:
 * chrome
 * edge
 * firefox
-* firefox-nightly (requires setting `ENV['FIREFOX_NIGHTLY_BINARY']` with the path to the browser executable)
+* ie
 * safari
 * safari-preview
 

Rakefile

@@ -246,7 +246,6 @@ task test_rb: ['//rb:unit-test', :test_rb_local, :test_rb_remote]
 task test_rb_local: [
  '//rb:chrome-test',
  '//rb:firefox-test',
- ('//rb:firefox-nightly-test' if ENV['FIREFOX_NIGHTLY_BINARY']),
  ('//rb:safari-preview-test' if SeleniumRake::Checks.mac?),
  ('//rb:safari-test' if SeleniumRake::Checks.mac?),
  ('//rb:ie-test' if SeleniumRake::Checks.windows?),
@@ -256,7 +255,6 @@ task test_rb_local: [
 task test_rb_remote: [
  '//rb:remote-chrome-test',
  '//rb:remote-firefox-test',
- ('//rb:remote-firefox-nightly-test' if ENV['FIREFOX_NIGHTLY_BINARY']),
  ('//rb:remote-safari-test' if SeleniumRake::Checks.mac?),
  ('//rb:remote-safari-preview-test' if SeleniumRake::Checks.mac?),
  ('//rb:remote-ie-test' if SeleniumRake::Checks.windows?),

rb/spec/integration/selenium/webdriver/bidi_spec.rb

@@ -21,7 +21,7 @@
 
 module Selenium
  module WebDriver
- describe BiDi, exclusive: {browser: %i[chrome_beta firefox firefox_nightly]} do
+ describe BiDi, exclusive: {browser: %i[chrome_beta firefox]} do
  it 'gets session status' do
  status = driver.bidi.session.status
  expect(status).to respond_to(:ready)

rb/spec/integration/selenium/webdriver/devtools_spec.rb

@@ -21,7 +21,7 @@
 
 module Selenium
  module WebDriver
- describe DevTools, exclusive: {browser: %i[chrome edge firefox firefox_nightly]} do
+ describe DevTools, exclusive: {browser: %i[chrome edge firefox]} do
  after { reset_driver! }
 
  it 'sends commands' do
@@ -47,7 +47,7 @@ module WebDriver
  }.to raise_error(RuntimeError, "This is fine!")
  end
 
- context 'authentication', except: {browser: %i[firefox firefox_nightly],
+ context 'authentication', except: {browser: :firefox,
  reason: 'Fetch.enable is not yet supported'} do
  let(:username) { SpecSupport::RackServer::TestApp::BASIC_AUTH_CREDENTIALS.first }
  let(:password) { SpecSupport::RackServer::TestApp::BASIC_AUTH_CREDENTIALS.last }
@@ -95,7 +95,7 @@ module WebDriver
  )
  end
 
- it 'notifies about document log messages', except: {browser: %i[firefox firefox_nightly],
+ it 'notifies about document log messages', except: {browser: :firefox,
  reason: 'Firefox & Chrome parse document differently'} do
  logs = []
  driver.on_log_event(:console) { |log| logs.push(log) }
@@ -109,7 +109,7 @@ module WebDriver
  )
  end
 
- it 'notifies about document log messages', only: {browser: %i[firefox firefox_nightly],
+ it 'notifies about document log messages', only: {browser: :firefox,
  reason: 'Firefox & Chrome parse document differently'} do
  logs = []
  driver.on_log_event(:console) { |log| logs.push(log) }
@@ -136,7 +136,7 @@ module WebDriver
  expect(exception.stacktrace).not_to be_empty
  end
 
- it 'notifies about DOM mutations', except: {browser: %i[firefox firefox_nightly],
+ it 'notifies about DOM mutations', except: {browser: :firefox,
  reason: 'Runtime.addBinding not yet supported'} do
  mutations = []
  driver.on_log_event(:mutation) { |mutation| mutations.push(mutation) }
@@ -152,7 +152,7 @@ module WebDriver
  expect(mutation.old_value).to eq('display:none;')
  end
 
- context 'network interception', except: {browser: %i[firefox firefox_nightly],
+ context 'network interception', except: {browser: :firefox,
  reason: 'Fetch.enable is not yet supported'} do
  it 'continues requests' do
  requests = []
@@ -202,7 +202,7 @@ module WebDriver
  end
  end
 
- context 'script pinning', except: {browser: %i[firefox firefox_nightly]} do
+ context 'script pinning', except: {browser: :firefox} do
  before do
  driver.navigate.to url_for('xhtmlTest.html')
  end

rb/spec/integration/selenium/webdriver/element_spec.rb

@@ -102,7 +102,7 @@ module WebDriver
  end
 
  # https://github.com/mozilla/geckodriver/issues/245
- it 'should send key presses chords', except: {browser: %i[firefox firefox_nightly safari safari_preview]} do
+ it 'should send key presses chords', except: {browser: %i[firefox safari safari_preview]} do
  driver.navigate.to url_for('javascriptPage.html')
  key_reporter = driver.find_element(id: 'keyReporter')
 

rb/spec/integration/selenium/webdriver/manager_spec.rb

@@ -121,7 +121,7 @@ module WebDriver
  end
 
  it 'should not add secure cookie when http',
- except: [{browser: %i[firefox firefox_nightly],
+ except: [{browser: :firefox,
  reason: 'https://github.com/mozilla/geckodriver/issues/1840'},
  {browser: %i[chrome edge],
  reason: 'https://bugs.chromium.org/p/chromium/issues/detail?id=1177877#c7'}] do
@@ -145,15 +145,15 @@ module WebDriver
  end
 
  context 'sameSite' do
- it 'should allow adding with value Strict', only: {browser: %i[chrome edge firefox firefox_nightly]} do
+ it 'should allow adding with value Strict', only: {browser: %i[chrome edge firefox]} do
  driver.manage.add_cookie name: 'samesite',
  value: 'strict',
  same_site: 'Strict'
 
  expect(driver.manage.cookie_named('samesite')[:same_site]).to eq('Strict')
  end
 
- it 'should allow adding with value Lax', only: {browser: %i[chrome edge firefox firefox_nightly]} do
+ it 'should allow adding with value Lax', only: {browser: %i[chrome edge firefox]} do
  driver.manage.add_cookie name: 'samesite',
  value: 'lax',
  same_site: 'Lax'
@@ -174,7 +174,7 @@ module WebDriver
  end
 
  it 'should not allow adding with value None when secure is false',
- except: [{browser: %i[firefox firefox_nightly],
+ except: [{browser: :firefox,
  reason: "https://github.com/mozilla/geckodriver/issues/1842"},
  {browser: %i[safari safari_preview]}] do
  expect {

rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb

@@ -189,12 +189,6 @@ def create_firefox_driver(**opts)
  WebDriver::Driver.for(:firefox, options: options, **opts)
  end
 
- def create_firefox_nightly_driver(**opts)
- options = create_firefox_options(opts.delete(:options))
- options.binary = ENV['FIREFOX_NIGHTLY_BINARY'] if ENV.key?('FIREFOX_NIGHTLY_BINARY')
- WebDriver::Driver.for(:firefox, options: options, **opts)
- end
-
  def create_firefox_options(options)
  options ||= WebDriver::Options.firefox
  options.web_socket_url = true