Skip to content

Conversation

@lbendavid-cloudinary
Copy link
Contributor

Pull request for cloudinary/frontend-frameworks

For which package is this PR?

@cloudinary/vue3

What does this PR solve?

  1. The AdvancedImage didn't work in SSR. There was an issue in how the url was bounded to the img tag.
  2. Use the same analytics token in both SSR and CSR in order to prevent unnecessary requests from the browser
  3. Added tests for the analytics token in SSR

Final checklist

  • Implementation is aligned to Spec.
  • Tests - Add proper tests to the added code.
  • Relates to a github issue (link to issue).
@lbendavid-cloudinary lbendavid-cloudinary merged commit 61a86fb into master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants