Feature/replace micro-bundle with rollup (#131)

Author: patrick-tolosa

.travis.yml

@@ -1,12 +1,12 @@
 language: node_js
-node_js:
- - "12"
 addons:
  chrome: stable
-script:
- - npm run quickstart
- - npm run test
-
+matrix:
+ include:
+ - node_js: "12"
+ script: npm run quickstart && npm run test
+ - node_js: "14"
+ script: npm run quickstart && npm run test
 notifications:
  email:
  recipients:

packages/react/__tests__/package.tests.tsx

@@ -0,0 +1,16 @@
+import {execSync} from "child_process";
+import fs from 'fs';
+import * as path from "path";
+
+describe('tests for the package output', () => {
+ it('ensures that the pacakge contains the right files', () => {
+ execSync('npm run build');
+ const dirContents = fs.readdirSync(path.resolve(__dirname, '../dist'));
+
+ expect(dirContents.includes('index.js')).toBe(true);
+ expect(dirContents.includes('index.umd.js')).toBe(true);
+ expect(dirContents.includes('index.cjs.js')).toBe(true);
+ expect(dirContents.includes('index.d.ts')).toBe(true);
+ expect(dirContents.includes('package.json')).toBe(true);
+ });
+});

packages/react/package.json

@@ -5,17 +5,15 @@
  "author": "cloudinary",
  "license": "MIT",
  "repository": "https://github.com/cloudinary/frontend-frameworks",
- "main": "dist/index.js",
- "umd:main": "./dist/index.umd.js",
- "module": "dist/index.esm.js",
+ "main": "index.umd.js",
+ "module": "index.js",
+ "types": "index.d.ts",
  "sideEffects": false,
- "source": "src/index.tsx",
  "engines": {
  "node": ">=10"
  },
  "scripts": {
- "build": "npm run build --prefix ../html && microbundle --format esm,umd,cjs --jsx React.createElement --compress false && cp package.json ./dist",
- "start": "microbundle watch --no-compress --format modern,cjs",
+ "build": "npm run build --prefix ../html && tsc && rollup -c && cp package.json ./dist",
  "test": "jest",
  "test-coverage": "jest --coverage"
  },
@@ -53,14 +51,20 @@
  "eslint-plugin-react": "^7.17.0",
  "eslint-plugin-standard": "^4.0.1",
  "gh-pages": "^2.2.0",
- "microbundle": "^0.13.0",
  "npm-run-all": "^4.1.5",
  "prettier": "^2.0.4",
  "react": "^16.13.1",
  "react-dom": "^16.13.1",
  "react-scripts": "^3.4.1",
  "ts-jest": "^26.4.4",
- "typescript": "^3.7.5"
+ "typescript": "^3.7.5",
+ "@cloudinary/html": "^1.0.1",
+ "@rollup/plugin-commonjs": "^21.0.1",
+ "@rollup/plugin-json": "^4.1.0",
+ "@rollup/plugin-node-resolve": "^13.1.3",
+ "@rollup/plugin-replace": "^3.0.1",
+ "@rollup/plugin-typescript": "^8.3.0",
+ "rollup": "^2.66.1"
  },
  "jest": {
  "transformIgnorePatterns": [

packages/react/rollup.config.js

@@ -0,0 +1,35 @@
+import resolve from '@rollup/plugin-node-resolve';
+import typescript from '@rollup/plugin-typescript';
+import commonjs from '@rollup/plugin-commonjs';
+import replace from '@rollup/plugin-replace';
+import { version } from './package.json';
+
+export default [
+ {
+ input: 'src/index.tsx',
+ output: [
+ {
+ file: 'dist/index.umd.js',
+ format: 'umd',
+ name: 'CloudinaryBaseSDK'
+ },
+ {
+ file: 'dist/index.js',
+ format: 'esm'
+ },
+ {
+ file: 'dist/index.cjs.js',
+ format: 'cjs'
+ }
+ ],
+ plugins: [
+ resolve(),
+ replace({
+ PACKAGE_VERSION_INJECTED_DURING_BUILD: version,
+ preventAssignment: false
+ }),
+ typescript({ target: 'es5' }),
+ commonjs()
+ ]
+ }
+];

packages/react/src/internal/SDKAnalyticsConstants.ts

@@ -1,8 +1,7 @@
 import React from 'react'
-import { version } from '../../package.json';
 
 export const SDKAnalyticsConstants = {
- sdkSemver: version,
+ sdkSemver: 'PACKAGE_VERSION_INJECTED_DURING_BUILD',
  techVersion: React.version,
  sdkCode: 'J'
 };

packages/react/tsconfig.json

@@ -1,7 +1,7 @@
 {
  "compilerOptions": {
- "outDir": "dist",
  "module": "esnext",
+ "declarationDir" : "./dist",
  "lib": [
  "dom",
  "esnext"
@@ -27,12 +27,11 @@
  "forceConsistentCasingInFileNames": true,
  "resolveJsonModule": true,
  "isolatedModules": true,
- "noEmit": true,
- "types": ["jest", "node"]
+ "emitDeclarationOnly": true,
+ "types": ["jest", "node"],
+ "baseUrl": "src"
  },
- "include": [
- "src"
- ],
+ "include": ["src/index.tsx"],
  "exclude": [
  "node_modules",
  "dist",