Feat/issue 233 (#49)

Author: archit-cd

.deepsource.toml

@@ -1,4 +1,3 @@
 version = 1
-
 [[analyzers]]
-name = "terraform"
+name = "terraform"

.github/dependabot.yml

@@ -2,10 +2,8 @@
 # package ecosystems to update and where the package manifests are located.
 # Please see the documentation for all configuration options:
 # https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
-
 version: 2
 updates:
-
  - package-ecosystem: "github-actions"
  directory: "/"
  schedule:
@@ -43,7 +41,7 @@ updates:
  open-pull-requests-limit: 3
 
  - package-ecosystem: "terraform" # See documentation for possible values
- directory: "/_example/public-private-subnet-endpoint" # Location of package manifests
+ directory: "/_example/complete" # Location of package manifests
  schedule:
  interval: "weekly"
  # Add assignees
@@ -69,7 +67,7 @@ updates:
  open-pull-requests-limit: 3
 
  - package-ecosystem: "terraform" # See documentation for possible values
- directory: "/_example/public-private-subnet" # Location of package manifests
+ directory: "/_example/basic" # Location of package manifests
  schedule:
  interval: "weekly"
  # Add assignees
@@ -92,4 +90,5 @@ updates:
  reviewers:
  - "approvers"
  # Allow up to 3 open pull requests for pip dependencies
- open-pull-requests-limit: 3
+ open-pull-requests-limit: 3
+

.github/workflows/auto_assignee.yml

@@ -1,14 +1,12 @@
 name: Auto Assign PRs
-
 on:
  pull_request:
  types: [opened, reopened]
-
  workflow_dispatch:
 jobs:
- assign-pr:
+ assignee:
  uses: clouddrove/github-shared-workflows/.github/workflows/auto_assignee.yml@master
  secrets:
  GITHUB: ${{ secrets.GITHUB }}
  with:
- assignees: 'clouddrove-ci'
+ assignees: 'clouddrove-ci'

.github/workflows/changelog.yml

@@ -6,7 +6,7 @@ on:
  - "*"
  workflow_dispatch:
 jobs:
- call-workflow-changelog:
+ changelog:
  uses: clouddrove/github-shared-workflows/.github/workflows/changelog.yml@master
  secrets: inherit
  with:

.github/workflows/readme.yml

@@ -3,9 +3,8 @@ on:
  push:
  branches:
  - master
-
 jobs:
- readme-create:
+ readme:
  name: 'readme-create'
  runs-on: ubuntu-latest
  steps:
@@ -40,7 +39,7 @@ jobs:
  with:
  actions_subcommand: 'push'
  env:
- GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN}}
+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
  - name: 'Slack Notification'
  uses: clouddrove/action-slack@v2

.github/workflows/tf-checks.yml

@@ -12,15 +12,15 @@ jobs:
  tf-checks-basic-example:
  uses: clouddrove/github-shared-workflows/.github/workflows/tf-checks.yml@master
  with:
- working_directory: './_example/public-private-subnet-endpoint/'
+ working_directory: './_example/basic/'
  tf-checks-public-private-subnet-single-nat-gateway-example:
  uses: clouddrove/github-shared-workflows/.github/workflows/tf-checks.yml@master
  with:
  working_directory: './_example/public-private-subnet-single-nat-gateway/'
- tf-checks-public-private-subnet-example:
+ tf-checks-complete-example:
  uses: clouddrove/github-shared-workflows/.github/workflows/tf-checks.yml@master
  with:
- working_directory: './_example/public-private-subnet/'
+ working_directory: './_example/complete/'
  tf-checks-public-subnet-example:
  uses: clouddrove/github-shared-workflows/.github/workflows/tf-checks.yml@master
  with:

.github/workflows/tflint.yml

@@ -6,6 +6,6 @@ on:
  workflow_dispatch:
 jobs:
  tf-lint:
- uses: clouddrove/test-tfsec/.github/workflows/tflint.yaml@master
+ uses: clouddrove/github-shared-workflows/.github/workflows/tf-lint.yml@master
  secrets:
- GITHUB: ${{ secrets.GITHUB }}
+ GITHUB: ${{ secrets.GITHUB }}

README.yaml

@@ -5,7 +5,7 @@
 #
 
 # Name of this project
-name: Terraform AWS Subnet
+name : Terraform AWS Subnet
 
 # License of this project
 license: "APACHE"
@@ -25,6 +25,9 @@ badges:
  image: "https://img.shields.io/badge/License-APACHE-blue.svg"
  url: "LICENSE.md"
 
+prerequesties:
+ - name: Terraform 1.4.6
+ url: https://learn.hashicorp.com/terraform/getting-started/install.html
 # description of this project
 description: |-
  Terraform module to create public, private and public-private subnet with network acl, route table, Elastic IP, nat gateway, flow log.
@@ -40,97 +43,48 @@ usage: |-
  ```hcl
  module "private-subnets" {
  source = "clouddrove/terraform-aws-subnet/aws"
- version = "1.3.0"
  name = "subnets"
  environment = "test"
- label_order = ["name", "environment"]
  nat_gateway_enabled = true
  availability_zones = ["eu-west-1a", "eu-west-1b", "eu-west-1c"]
  vpc_id = module.vpc.vpc_id
  type = "private"
  cidr_block = module.vpc.vpc_cidr_block
  ipv6_cidr_block = module.vpc.ipv6_cidr_block
  public_subnet_ids = ["subnet-xxxxxxxxxxxx", "subnet-xxxxxxxxxxxx"]
-  }
+ }
  ```
 
  ### PUBLIC-PRIVATE SUBNET
  ```hcl
  module "subnets" {
- source = "clouddrove/terraform-aws-subnet/aws"
- version = "1.3.0"
- name = "subnets"
- environment = "test"
- label_order = ["name", "environment"]
-
- nat_gateway_enabled = true
- availability_zones = ["eu-west-1a", "eu-west-1b", "eu-west-1c"]
- vpc_id = module.vpc.vpc_id
- type = "public-private"
- igw_id = module.vpc.igw_id
- cidr_block = module.vpc.vpc_cidr_block
- ipv6_cidr_block = module.vpc.ipv6_cidr_block
- assign_ipv6_address_on_creation = false
- }
- ```
-
- ### PUBLIC-PRIVATE SUBNET WITH SINGLE NET GATEWAY
- ```hcl
- module "subnets" {
- source = "clouddrove/terraform-aws-subnet/aws"
- version = "1.3.0"
- name = "subnets"
- environment = "test"
- label_order = ["name", "environment"]
- availability_zones = ["eu-west-1a", "eu-west-1b", "eu-west-1c"]
- nat_gateway_enabled = true
- single_nat_gateway = true
- vpc_id = module.vpc.vpc_id
- type = "public-private"
- igw_id = module.vpc.igw_id
- cidr_block = module.vpc.vpc_cidr_block
- ipv6_cidr_block = module.vpc.ipv6_cidr_block
- assign_ipv6_address_on_creation = false
+ source = "clouddrove/terraform-aws-subnet/aws"
+ name = "subnets"
+ environment = "test"
+ label_order = ["name", "environment"]
+ nat_gateway_enabled = true
+ availability_zones = ["eu-west-1a", "eu-west-1b", "eu-west-1c"]
+ vpc_id = module.vpc.vpc_id
+ type = "public-private"
+ igw_id = module.vpc.igw_id
+ cidr_block = module.vpc.vpc_cidr_block
+ ipv6_cidr_block = module.vpc.ipv6_cidr_block
+ enable_ipv6 = true
  }
  ```
 
  ### PUBLIC SUBNET
  ```hcl
  module "subnets" {
  source = "clouddrove/terraform-aws-subnet/aws"
- version = "1.3.0"
  name = "subnets"
  environment = "test"
  label_order = ["name", "environment"]
- availability_zones = ["eu-west-1a", "eu-west-1b", "eu-west-1c"]
+ availability_zones = ["us-east-1a", "us-east-1b", "us-east-1c"]
  vpc_id = module.vpc.vpc_id
  type = "public"
  igw_id = module.vpc.igw_id
- cidr_block = module.vpc.vpc_cidr_block
- ipv6_cidr_block = module.vpc.ipv6_cidr_block
- assign_ipv6_address_on_creation = false
-
+ ipv4_public_cidrs = ["10.0.1.0/24", "10.0.13.0/24", "10.0.18.0/24"]
+ enable_ipv6 = false
  }
- ```
-
- ### PUBLIC-PRIVATE-SUBNET-ENDPOINT
- ```hcl
- module "subnets" {
- source = "clouddrove/terraform-aws-subnet/aws"
- version = "1.3.0"
- name = "subnets"
- environment = "prashant"
- label_order = ["name", "environment"]
-
- nat_gateway_enabled = true
- availability_zones = ["eu-west-1a", "eu-west-1b", "eu-west-1c"]
- vpc_id = module.vpc.vpc_id
- type = "public-private"
- igw_id = module.vpc.igw_id
- cidr_block = module.vpc.vpc_cidr_block
- ipv6_cidr_block = module.vpc.ipv6_cidr_block
- assign_ipv6_address_on_creation = false
- enable_vpc_endpoint = true
- service_name = "com.amazonaws.${data.aws_region.current.name}.ec2"
- }
- ```
+ ```

_example/basic/example.tf

@@ -0,0 +1,18 @@
+##----------------------------------------------------------------------------- 
+## Subnet Module Call. 
+## Both private and public subnet will be deployed. 
+##-----------------------------------------------------------------------------
+#tfsec:ignore:aws-ec2-no-excessive-port-access 
+#tfsec:ignore:aws-ec2-no-public-ingress-acl
+module "subnets" {
+ source = "./../../"
+ name = "subnets"
+ environment = "test"
+ nat_gateway_enabled = true
+ availability_zones = ["eu-west-1a", "eu-west-1b", "eu-west-1c"]
+ vpc_id = "vpv_id-------"
+ type = "public-private"
+ igw_id = "vpc_igw_id---"
+ cidr_block = "10.0.0.0/16"
+ enable_ipv6 = false
+}