Skip to content

Conversation

alexander-yakushev
Copy link
Member

@alexander-yakushev alexander-yakushev commented Feb 26, 2025

  1. Remove code responsible for rendering Javadoc fragments (already dropped from cider-nrepl).
  2. Remove compatibility code that was introduced together with the javadoc fragment code – use the new approach exclusively. I'm not sure what the compatibility code was for; perhaps, for cases when people relied on those functions in their Emacs config somehow. Anyway, a few years has passed already.
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the user manual (if adding/changing user-visible functionality)
@alexander-yakushev alexander-yakushev force-pushed the inspector-cleanup branch 3 times, most recently from 34dd412 to 71a7d45 Compare February 26, 2025 14:51
Copy link
Member

@bbatsov bbatsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

@bbatsov
Copy link
Member

bbatsov commented Feb 26, 2025

We might want to do the OS integration tests just on one version of Emacs, as those are taking forever. I came back to merge this PR only to see the CI is still in progress one hour later.

@alexander-yakushev alexander-yakushev merged commit 531c91e into master Feb 26, 2025
45 checks passed
@alexander-yakushev alexander-yakushev deleted the inspector-cleanup branch February 26, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants