Skip to content

Commit d12dbb7

Browse files
chrisbobbegnprice
authored andcommitted
msglist [nfc]: Remove a TODO for finding some dark-theme colors
For the background color, the unread-marker color seems like a very reasonable starting point, since that's what we're using in light theme. White seems reasonable for dark theme, just like in light theme. There shouldn't be an issue with contrast; I expect the background will be darker, if anything, in dark theme. We can always refine these styles later.
1 parent e267589 commit d12dbb7

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

lib/widgets/message_list.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -534,7 +534,6 @@ class _MarkAsReadWidgetState extends State<MarkAsReadWidget> {
534534
// Give the buttons a constant color regardless of whether their
535535
// state is disabled, pressed, etc. We handle those states
536536
// separately, via MarkAsReadAnimation.
537-
// TODO(#95) need dark-theme colors (foreground and background)
538537
foregroundColor: WidgetStateColor.resolveWith((_) => Colors.white),
539538
backgroundColor: WidgetStateColor.resolveWith((_) => _UnreadMarker.color),
540539
),

0 commit comments

Comments
 (0)