updates & fixes

Author: chilio

commands/chrome-system-check.sh

@@ -11,8 +11,8 @@ echo ${SYSTEMCHROMEDRIVER}
 printf "${GREEN}Laravel Chromedriver version: ${NC}"
 LARAVELCHROMEDRIVER=`$(pwd)/vendor/laravel/dusk/bin/chromedriver-linux --version | grep -iEo -m 1 "[0-9]{1,3}.[0-9]{1,3}" | head -1`
 echo ${LARAVELCHROMEDRIVER}
-# php /usr/bin/dusk-versions-check.php ${SYSTEMCHROME} ${SYSTEMCHROMEDRIVER} ${LARAVELCHROMEDRIVER} 1
-COMPATIBLE=`php /usr/bin/dusk-versions-check.php ${SYSTEMCHROME} ${SYSTEMCHROMEDRIVER} ${LARAVELCHROMEDRIVER} 1`
+php /usr/bin/dusk-versions-check.php ${SYSTEMCHROME} ${SYSTEMCHROMEDRIVER} ${LARAVELCHROMEDRIVER} 1
+COMPATIBLE=`php /usr/bin/dusk-versions-check.php ${SYSTEMCHROME} ${SYSTEMCHROMEDRIVER} ${LARAVELCHROMEDRIVER} 0`
 print "${COMPATIBLE}"
 if [${COMPATIBLE} == "INCOMPATIBLE"]; then
  printf "${GREEN}Starting system Chromedriver (${SYSTEMCHROMEDRIVER}).\n"

commands/dusk-versions-check.php

@@ -7,7 +7,7 @@
 $system_chrome = $argv[1];
 $system_chromedriver = $argv[2];
 $laravel_chromedriver = $argv[3];
-$print_info = $argv[4];
+$print_info_only = $argv[4];
 
 $compatible = FALSE;
 if ($system_chromedriver == $laravel_chromedriver) {
@@ -20,7 +20,7 @@
  }
  }
 }
-if ($print_info) {
+if ($print_info_only) {
  if ($compatible) {
  print $green."Laravel Chromedriver check => PASSED OK.".PHP_EOL;
  print $yellow."You can use both Chromedriver shipped with Laravel (".$laravel_chromedriver.") or system Chromeriver (".$system_chromedriver.")".PHP_EOL;
@@ -34,5 +34,7 @@
  print $yellow."You can read more, about running tests with systems inbuilt chromedriver in laravel-dusk-ci docs.".PHP_EOL;
  }
  print $nocolor;
+} else {
+ print ($compatible?"OK":"INCOMPATIBLE");
 }
-print ($compatible?"OK":"INCOMPATIBLE");
+