Search: fix SearchEngineRef mapping and add resource_node FK migration

Author: christianbeeznest

src/CoreBundle/Entity/Course.php

@@ -241,28 +241,12 @@ class Course extends AbstractResource implements ResourceInterface, ResourceWith
  #[ORM\OneToMany(mappedBy: 'course', targetEntity: TrackEHotspot::class, cascade: ['persist', 'remove'])]
  protected Collection $trackEHotspots;
 
- /**
- * @var Collection<int, SearchEngineRef>
- */
- #[ORM\OneToMany(mappedBy: 'course', targetEntity: SearchEngineRef::class, cascade: ['persist', 'remove'])]
- protected Collection $searchEngineRefs;
-
  /**
  * @var Collection<int, Templates>
  */
  #[ORM\OneToMany(mappedBy: 'course', targetEntity: Templates::class, cascade: ['persist', 'remove'])]
  protected Collection $templates;
 
- /**
- * ORM\OneToMany(targetEntity="Chamilo\CoreBundle\Entity\SpecificFieldValues", mappedBy="course").
- */
- // protected $specificFieldValues;
-
- /**
- * ORM\OneToMany(targetEntity="Chamilo\CoreBundle\Entity\SharedSurvey", mappedBy="course").
- */
- // protected $sharedSurveys;
-
  #[ORM\Column(name: 'directory', type: 'string', length: 40, unique: false, nullable: true)]
  protected ?string $directory = null;
 
@@ -410,7 +394,6 @@ public function __construct()
  $this->gradebookEvaluations = new ArrayCollection();
  $this->gradebookLinks = new ArrayCollection();
  $this->trackEHotspots = new ArrayCollection();
- $this->searchEngineRefs = new ArrayCollection();
  $this->templates = new ArrayCollection();
  $this->activateLegal = 0;
  $this->addTeachersToSessionsCourses = false;
@@ -420,8 +403,6 @@ public function __construct()
  $this->subscribe = true;
  $this->unsubscribe = false;
  $this->sticky = false;
- // $this->specificFieldValues = new ArrayCollection();
- // $this->sharedSurveys = new ArrayCollection();
  }
 
  public function __toString(): string
@@ -1138,21 +1119,6 @@ public function setTrackEHotspots(Collection $trackEHotspots): self
  return $this;
  }
 
- /**
- * @return Collection<int, SearchEngineRef>
- */
- public function getSearchEngineRefs(): Collection
- {
- return $this->searchEngineRefs;
- }
-
- public function setSearchEngineRefs(Collection $searchEngineRefs): self
- {
- $this->searchEngineRefs = $searchEngineRefs;
-
- return $this;
- }
-
  public function getIntroduction(): ?string
  {
  return $this->introduction;

src/CoreBundle/Entity/SearchEngineRef.php

@@ -8,37 +8,35 @@
 
 use Doctrine\ORM\Mapping as ORM;
 
-/**
- * SearchEngineRef.
- */
 #[ORM\Table(name: 'search_engine_ref')]
 #[ORM\Entity]
 class SearchEngineRef
 {
- #[ORM\Column(name: 'resource_node_id', type: 'integer', nullable: true)]
- protected ?int $resourceNodeId = null;
+ #[ORM\ManyToOne(targetEntity: ResourceNode::class)]
+ #[ORM\JoinColumn(name: 'resource_node_id', referencedColumnName: 'id', nullable: true, onDelete: 'CASCADE')]
+ private ?ResourceNode $resourceNode = null;
 
  #[ORM\Column(name: 'search_did', type: 'integer', nullable: false)]
- protected int $searchDid;
+ private int $searchDid;
 
- #[ORM\Column(name: 'id', type: 'integer')]
  #[ORM\Id]
+ #[ORM\Column(name: 'id', type: 'integer')]
  #[ORM\GeneratedValue(strategy: 'IDENTITY')]
- protected ?int $id = null;
+ private ?int $id = null;
 
  public function getId(): ?int
  {
  return $this->id;
  }
 
- public function getResourceNodeId(): ?int
+ public function getResourceNode(): ?ResourceNode
  {
- return $this->resourceNodeId;
+ return $this->resourceNode;
  }
 
- public function setResourceNodeId(?int $resourceNodeId): self
+ public function setResourceNode(?ResourceNode $resourceNode): self
  {
- $this->resourceNodeId = $resourceNodeId;
+ $this->resourceNode = $resourceNode;
 
  return $this;
  }

src/CoreBundle/Migrations/Schema/V200/Version20251216095100.php

@@ -0,0 +1,51 @@
+<?php
+
+declare(strict_types=1);
+
+/* For licensing terms, see /license.txt */
+
+namespace Chamilo\CoreBundle\Migrations\Schema\V200;
+
+use Chamilo\CoreBundle\Migrations\AbstractMigrationChamilo;
+use Doctrine\DBAL\Schema\Schema;
+
+final class Version20251216095100 extends AbstractMigrationChamilo
+{
+ public function getDescription(): string
+ {
+ return 'Add FK + index for search_engine_ref.resource_node_id (resource_node.id).';
+ }
+
+ public function up(Schema $schema): void
+ {
+ // Ensure the FK can be created (remove orphan references).
+ $this->addSql("
+ UPDATE search_engine_ref ser
+ SET resource_node_id = NULL
+ WHERE ser.resource_node_id IS NOT NULL
+ AND NOT EXISTS (
+ SELECT 1
+ FROM resource_node rn
+ WHERE rn.id = ser.resource_node_id
+ )
+ ");
+
+ // Add index for faster joins and stable naming.
+ $this->addSql('CREATE INDEX IDX_473F03781BAD783F ON search_engine_ref (resource_node_id)');
+
+ // Add FK constraint.
+ $this->addSql("
+ ALTER TABLE search_engine_ref
+ ADD CONSTRAINT FK_473F03781BAD783F
+ FOREIGN KEY (resource_node_id)
+ REFERENCES resource_node (id)
+ ON DELETE CASCADE
+ ");
+ }
+
+ public function down(Schema $schema): void
+ {
+ $this->addSql('ALTER TABLE search_engine_ref DROP FOREIGN KEY FK_473F03781BAD783F');
+ $this->addSql('DROP INDEX IDX_473F03781BAD783F ON search_engine_ref');
+ }
+}