Return nil instead of :default in resource methods

Author: lgebhardt

lib/jsonapi/operation.rb

@@ -149,7 +149,7 @@ def apply(context)
  resource = @resource_klass.create(context)
  result = resource.replace_fields(@data)
 
- return JSONAPI::ResourceOperationResult.new(result == :default ? :created : result, resource)
+ return JSONAPI::ResourceOperationResult.new((result ? result : :created), resource)
 
  rescue JSONAPI::Exceptions::Error => e
  return JSONAPI::ErrorsOperationResult.new(e.errors[0].code, e.errors)
@@ -187,7 +187,7 @@ def apply(context)
  resource = @resource_klass.find_by_key(@resource_id, context: context)
  result = resource.replace_fields(data)
 
- return JSONAPI::ResourceOperationResult.new(result == :default ? :ok : result, resource)
+ return JSONAPI::ResourceOperationResult.new(result ? result : :ok, resource)
  end
  end
 
@@ -205,7 +205,7 @@ def apply(context)
  resource = @resource_klass.find_by_key(@resource_id, context: context)
  result = resource.replace_has_one_link(@association_type, @key_value)
 
- return JSONAPI::OperationResult.new(result == :default ? :no_content : result)
+ return JSONAPI::OperationResult.new(result ? result : :no_content)
  end
  end
 
@@ -223,7 +223,7 @@ def apply(context)
  resource = @resource_klass.find_by_key(@resource_id, context: context)
  result = resource.create_has_many_links(@association_type, @data)
 
- return JSONAPI::OperationResult.new(result == :default ? :no_content : result)
+ return JSONAPI::OperationResult.new(result ? result : :no_content)
  end
  end
 
@@ -241,7 +241,7 @@ def apply(context)
  resource = @resource_klass.find_by_key(@resource_id, context: context)
  result = resource.replace_has_many_links(@association_type, @data)
 
- return JSONAPI::OperationResult.new(result == :default ? :no_content : result)
+ return JSONAPI::OperationResult.new(result ? result : :no_content)
  end
  end
 
@@ -259,7 +259,7 @@ def apply(context)
  resource = @resource_klass.find_by_key(@resource_id, context: context)
  result = resource.remove_has_many_link(@association_type, @associated_key)
 
- return JSONAPI::OperationResult.new(result == :default ? :no_content : result)
+ return JSONAPI::OperationResult.new(result ? result : :no_content)
  end
  end
 
@@ -276,7 +276,7 @@ def apply(context)
  resource = @resource_klass.find_by_key(@resource_id, context: context)
  result = resource.remove_has_one_link(@association_type)
 
- return JSONAPI::OperationResult.new(result == :default ? :no_content : result)
+ return JSONAPI::OperationResult.new(result ? result : :no_content)
  end
  end
 end

lib/jsonapi/resource.rb

@@ -124,7 +124,7 @@ def _save
  saved = @model.save
  @save_needed = !saved
 
- return :default
+ return
  end
 
  def _remove
@@ -146,7 +146,7 @@ def _create_has_many_links(association_type, association_key_values)
  end
  end
 
- return :default
+ return
  end
 
  def _replace_has_many_links(association_type, association_key_values)
@@ -155,7 +155,7 @@ def _replace_has_many_links(association_type, association_key_values)
  send("#{association.foreign_key}=", association_key_values)
  @save_needed = true
 
- return :default
+ return
  end
 
  def _replace_has_one_link(association_type, association_key_value)
@@ -170,7 +170,7 @@ def _remove_has_many_link(association_type, key)
 
  @model.send(association.type).delete(key)
 
- return :default
+ return
  end
 
  def _remove_has_one_link(association_type)