Refactor: cleanup unused (old) method (logstash-plugins#217)

was used in V1 - no longer relevant with aws-sdk 2.x

Author: kares

lib/logstash/outputs/s3.rb

@@ -326,10 +326,6 @@ def bucket_resource
  Aws::S3::Bucket.new(@bucket, full_options)
  end
 
- def aws_service_endpoint(region)
- { :s3_endpoint => region == 'us-east-1' ? 's3.amazonaws.com' : "s3-#{region}.amazonaws.com"}
- end
-
  def rotate_if_needed(prefixes)
  prefixes.each do |prefix|
  # Each file access is thread safe,

spec/outputs/s3_spec.rb

@@ -204,4 +204,27 @@
  subject.multi_receive_encoded(events_and_encoded)
  end
  end
+
+ describe "aws service" do
+ context 'us-east-1' do
+ let(:region) { 'us-east-1' }
+ it "sets endpoint" do
+ expect( subject.send(:bucket_resource).client.config.endpoint.to_s ).to eql 'https://s3.us-east-1.amazonaws.com'
+ end
+ end
+
+ context 'ap-east-1' do
+ let(:region) { 'ap-east-1' }
+ it "sets endpoint" do
+ expect( subject.send(:bucket_resource).client.config.endpoint.to_s ).to eql 'https://s3.ap-east-1.amazonaws.com'
+ end
+ end
+
+ context 'cn-northwest-1' do
+ let(:region) { 'cn-northwest-1' }
+ it "sets endpoint" do
+ expect( subject.send(:bucket_resource).client.config.endpoint.to_s ).to eql 'https://s3.cn-northwest-1.amazonaws.com.cn'
+ end
+ end
+ end
 end